Re: [PATCH v4 00/10] COLO: improve build options

[Vladimir Sementsov-Ogievskiy]

On 05.05.23 10:56, Zhang, Chen wrote:
> > -----Original Message-----
> > From: Vladimir Sementsov-Ogievskiy<vsementsov@yandex-team.ru>
> > Sent: Saturday, April 29, 2023 3:49 AM
> > To:qemu-devel@nongnu.org
> > Cc:lukasstraub2@web.de;quintela@redhat.com; Zhang, Chen
> > <chen.zhang@intel.com>;vsementsov@yandex-team.ru
> > Subject: [PATCH v4 00/10] COLO: improve build options
> >
> > v4:
> > 01: add r-b by Lukas
> > 02: new
> > 03: - keep x-colo capability enum value unconditional
> >      - drop ifdefs in options.c and keep capability check instead
> >      - update stubs
> >      - add missed a-b by Dr. David
> > 04: keep filter-mirror untouched, add r-b by Juan
> >
> > others: new. Some further improvements of COLO module API. May be
> > merged separately.
> >
> > Hi all!
> >
> > COLO substem seems to be useless when CONFIG_REPLICATION is unset, as
> > we simply don't allow to set x-colo capability in this case. So, let's not 
> > compile
> > in unreachable code and interface we cannot use when
> > CONFIG_REPLICATION is unset.
> >
> > Also, provide personal configure option for COLO Proxy subsystem.
> This series looks good to me.
> Please add the new configure option related comments to docs/COLO-FT.txt, 
> block-replication.txt, colo-proxy.txt.


Thanks! Will do.

--
Best regards,
Vladimir