[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 07/11] numa: Check for qemu_strtosz_MiB error
|
From: |
Eric Blake |
|
Subject: |
Re: [PATCH 07/11] numa: Check for qemu_strtosz_MiB error |
|
Date: |
Mon, 8 May 2023 16:15:21 -0500 |
|
User-agent: |
NeoMutt/20230407 |
On Mon, May 08, 2023 at 03:03:39PM -0500, Eric Blake wrote:
> As shown in the previous commit, qemu_strtosz_MiB sometimes leaves the
> result value untoutched (we have to audit further to learn that in
untouched
> that case, the QAPI generator says that visit_type_NumaOptions() will
> have zero-initialized it), and sometimes leaves it with the value of a
> partial parse before -EINVAL occurs because of trailing garbage.
> Rather than blindly treating any string the user may throw at us as
> valid, we should check for parse failures.
>
> Fiuxes: cc001888 ("numa: fixup parsed NumaNodeOptions earlier", v2.11.0)
> Signed-off-by: Eric Blake <eblake@redhat.com>
> ---
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
- [PATCH 08/11] cutils: Set value in all qemu_strtosz* error paths, (continued)
[PATCH 02/11] test-cutils: Use g_assert_cmpuint where appropriate, Eric Blake, 2023/05/08
[PATCH 01/11] test-cutils: Avoid g_assert in unit tests, Eric Blake, 2023/05/08
[PATCH 07/11] numa: Check for qemu_strtosz_MiB error, Eric Blake, 2023/05/08
- Re: [PATCH 07/11] numa: Check for qemu_strtosz_MiB error,
Eric Blake <=
[PATCH 03/11] test-cutils: Test integral qemu_strto* value on failures, Eric Blake, 2023/05/08
[PATCH 06/11] test-cutils: Add more coverage to qemu_strtosz, Eric Blake, 2023/05/08
[PATCH 10/11] cutils: Improve qemu_strtod* error paths, Eric Blake, 2023/05/08
Re: [PATCH 00/11] Fix qemu_strtosz() read-out-of-bounds, Hanna Czenczek, 2023/05/09