Re: RE: [PATCH] virtio-crypto: fix NULL pointer dereference in virtio_crypto_free_request

[zhenwei pi]

On 5/9/23 09:02, Gonglei (Arei) wrote:
> > -----Original Message-----
> > From: Mauro Matteo Cascella [mailto:mcascell@redhat.com]
> > Sent: Monday, May 8, 2023 11:02 PM
> > To: qemu-devel@nongnu.org
> > Cc: mst@redhat.com; Gonglei (Arei) <arei.gonglei@huawei.com>;
> > pizhenwei@bytedance.com; taoym@zju.edu.cn; mcascell@redhat.com
> > Subject: [PATCH] virtio-crypto: fix NULL pointer dereference in
> > virtio_crypto_free_request
> >
> > Ensure op_info is not NULL in case of QCRYPTODEV_BACKEND_ALG_SYM
> > algtype.
> >
> > Fixes: 02ed3e7c ("virtio-crypto: zeroize the key material before free")
>
> I have to say the fixes is incorrect. The bug was introduced by commit 
> 0e660a6f90a, which
> changed the semantic meaning of request-> flag.
>
> Regards,
> -Gonglei

Hi Mauro

Agree with Lei, could you please change the Fixes as Lei suggested?

--
zhenwei pi