[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 02/16] test-aio-multithread: do not use mb_read/mb_set for simple
|
From: |
Paolo Bonzini |
|
Subject: |
[PULL 02/16] test-aio-multithread: do not use mb_read/mb_set for simple flags |
|
Date: |
Tue, 9 May 2023 11:04:39 +0200 |
The remaining use of mb_read/mb_set is just to force a thread to exit
eventually. It does not order two memory accesses and therefore can be
just read/set.
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
tests/unit/test-aio-multithread.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/tests/unit/test-aio-multithread.c
b/tests/unit/test-aio-multithread.c
index a555cc883505..3c61526a0b46 100644
--- a/tests/unit/test-aio-multithread.c
+++ b/tests/unit/test-aio-multithread.c
@@ -202,7 +202,7 @@ static CoMutex comutex;
static void coroutine_fn test_multi_co_mutex_entry(void *opaque)
{
- while (!qatomic_mb_read(&now_stopping)) {
+ while (!qatomic_read(&now_stopping)) {
qemu_co_mutex_lock(&comutex);
counter++;
qemu_co_mutex_unlock(&comutex);
@@ -236,7 +236,7 @@ static void test_multi_co_mutex(int threads, int seconds)
g_usleep(seconds * 1000000);
- qatomic_mb_set(&now_stopping, true);
+ qatomic_set(&now_stopping, true);
while (running > 0) {
g_usleep(100000);
}
@@ -327,7 +327,7 @@ static void mcs_mutex_unlock(void)
static void test_multi_fair_mutex_entry(void *opaque)
{
- while (!qatomic_mb_read(&now_stopping)) {
+ while (!qatomic_read(&now_stopping)) {
mcs_mutex_lock();
counter++;
mcs_mutex_unlock();
@@ -355,7 +355,7 @@ static void test_multi_fair_mutex(int threads, int seconds)
g_usleep(seconds * 1000000);
- qatomic_mb_set(&now_stopping, true);
+ qatomic_set(&now_stopping, true);
while (running > 0) {
g_usleep(100000);
}
@@ -383,7 +383,7 @@ static QemuMutex mutex;
static void test_multi_mutex_entry(void *opaque)
{
- while (!qatomic_mb_read(&now_stopping)) {
+ while (!qatomic_read(&now_stopping)) {
qemu_mutex_lock(&mutex);
counter++;
qemu_mutex_unlock(&mutex);
@@ -411,7 +411,7 @@ static void test_multi_mutex(int threads, int seconds)
g_usleep(seconds * 1000000);
- qatomic_mb_set(&now_stopping, true);
+ qatomic_set(&now_stopping, true);
while (running > 0) {
g_usleep(100000);
}
--
2.40.1
- [PULL 00/16] Misc patches for 2023-05-09, Paolo Bonzini, 2023/05/09
- [PULL 02/16] test-aio-multithread: do not use mb_read/mb_set for simple flags,
Paolo Bonzini <=
- [PULL 01/16] rcu: remove qatomic_mb_set, expand comments, Paolo Bonzini, 2023/05/09
- [PULL 03/16] test-aio-multithread: simplify test_multi_co_schedule, Paolo Bonzini, 2023/05/09
- [PULL 04/16] call_rcu: stop using mb_set/mb_read, Paolo Bonzini, 2023/05/09
- [PULL 07/16] include/qemu/osdep.h: Bump _WIN32_WINNT to the Windows 8 API, Paolo Bonzini, 2023/05/09
- [PULL 05/16] tb-maint: do not use mb_read/mb_set, Paolo Bonzini, 2023/05/09
- [PULL 09/16] target/i386: Add new EPYC CPU versions with updated cache_info, Paolo Bonzini, 2023/05/09
- [PULL 06/16] MAINTAINERS: add stanza for Kconfig files, Paolo Bonzini, 2023/05/09
- [PULL 08/16] target/i386: allow versioned CPUs to specify new cache_info, Paolo Bonzini, 2023/05/09
- [PULL 12/16] target/i386: Add missing feature bits in EPYC-Milan model, Paolo Bonzini, 2023/05/09
- [PULL 11/16] target/i386: Add feature bits for CPUID_Fn80000021_EAX, Paolo Bonzini, 2023/05/09