[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] ui/dbus: Implement damage regions for GL
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH] ui/dbus: Implement damage regions for GL |
|
Date: |
Tue, 9 May 2023 17:18:34 +0200 |
|
User-agent: |
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 |
On 9/5/23 17:04, Bilal Elmoussaoui wrote:
cairo declared as optional dep, ...
I don't see where cairo is marked as an optional dependency, the `cairo
= not_found` part could probably be dropped to make it clearer.
I was expecting:
.require(cairo.found(), error_message: '-display dbus requires cairo')
On Tue, May 9, 2023 at 4:34 PM Philippe Mathieu-Daudé <philmd@linaro.org
<mailto:philmd@linaro.org>> wrote:
Hi,
On 9/5/23 13:59, Bilal Elmoussaoui wrote:
> From: Christian Hergert <chergert@redhat.com
<mailto:chergert@redhat.com>>
> diff --git a/ui/dbus-listener.c b/ui/dbus-listener.c
> index 911acdc529..047be5cb3a 100644
> --- a/ui/dbus-listener.c
> +++ b/ui/dbus-listener.c
> @@ -25,6 +25,7 @@
> #include "qemu/error-report.h"
> #include "sysemu/sysemu.h"
> #include "dbus.h"
> +#include <cairo.h>
cairo used unconditionally.
Shouldn't we now declared it as a strict dependency in meson?
> #include <gio/gunixfdlist.h>
>
> #ifdef CONFIG_OPENGL