qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH HOTFIX] target/loongarch: Terminate vmstate subsections list


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH HOTFIX] target/loongarch: Terminate vmstate subsections list
Date: Wed, 10 May 2023 17:09:37 +0200
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.10.1

On 10/5/23 08:24, Richard Henderson wrote:
This list requires a NULL terminator.

Fixes: 16f5396cec23 ("target/loongarch: Add LSX data type VReg")
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---

This failure can be seen

https://gitlab.com/qemu-project/qemu/-/jobs/4253259728#L5579

   5/789 qemu:qtest+qtest-loongarch64 / qtest-loongarch64/qom-test              
   ERROR           1.38s   killed by signal 6 SIGABRT
  44/789 qemu:qtest+qtest-loongarch64 / qtest-loongarch64/test-hmp              
   ERROR           0.95s   killed by signal 6 SIGABRT
356/789 qemu:qtest+qtest-loongarch64 / qtest-loongarch64/machine-none-test      
  ERROR           0.51s   killed by signal 6 SIGABRT

It does not always fail, depending on the layout of the executable,
which is why it was not caught right away.  I plan on applying this
directly to master before processing more pull requests.


r~

---
  target/loongarch/machine.c | 1 +
  1 file changed, 1 insertion(+)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]