qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 1/4] migration/calc-dirty-rate: replaced CRC32 with xxHash


From: Juan Quintela
Subject: Re: [PATCH v2 1/4] migration/calc-dirty-rate: replaced CRC32 with xxHash
Date: Wed, 10 May 2023 18:54:58 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)

Andrei Gudkov <gudkov.andrei@huawei.com> wrote:
> This significantly reduces overhead of dirty page
> rate calculation in sampling mode.
> Tested using 32GiB VM on E5-2690 CPU.
>
> With CRC32:
> total_pages=8388608 sampled_pages=16384 millis=71
>
> With xxHash:
> total_pages=8388608 sampled_pages=16384 millis=14
>
> Signed-off-by: Andrei Gudkov <gudkov.andrei@huawei.com>


Reviewed-by: Juan Quintela <quintela@redhat.com>

This changes nothing outside of dirtyrate, and if the hash function is
faster, we should be good.

queued.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]