qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 27/27] mkvenv.py: experiment; use distlib to generate script


From: Paolo Bonzini
Subject: Re: [PATCH 27/27] mkvenv.py: experiment; use distlib to generate script entry points
Date: Thu, 11 May 2023 08:57:07 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0

On 5/11/23 05:54, John Snow wrote:
This is an experiment: by using pip's internal vendored distlib, we can
generate script entry points for Windows, Mac and Linux using distlib's
mechanisms. This is the same mechanism used when running "pip install",
so it will be consistent with the most common method of package
installation on all platforms. It also allows us to delete a good bit of
vendored/borrowed code from inside of mkvenv.py, so there's less to
maintain and the license might be more straightforward.

As a downside, if we're not willing to actually add a distlib
requirement, we have to piggy-back on pip's vendored version, which
could have downsides if they move our cheese in the future.

I think the downsides are limited since you're trying both the "real" distlib and pip's. Overall I like this, though I haven't made up my mind if it should be split and squashed earlier in the series.

Paolo




reply via email to

[Prev in Thread] Current Thread [Next in Thread]