Re: [PATCH for-8.1] target/sparc: Use tcg_gen_lookup_and_goto_ptr

[Mark Cave-Ayland]

On 10/05/2023 11:23, Richard Henderson wrote:

> Ping.
>
> r~
>
> On 4/5/23 19:59, Richard Henderson wrote:
> > Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> > ---
> >   target/sparc/translate.c | 8 ++++----
> >   1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/target/sparc/translate.c b/target/sparc/translate.c
> > index 137bdc5159..47940fd85e 100644
> > --- a/target/sparc/translate.c
> > +++ b/target/sparc/translate.c
> > @@ -322,7 +322,7 @@ static void gen_goto_tb(DisasContext *s, int tb_num,
> >           /* jump to another page: currently not optimized */
> >           tcg_gen_movi_tl(cpu_pc, pc);
> >           tcg_gen_movi_tl(cpu_npc, npc);
> > -        tcg_gen_exit_tb(NULL, 0);
> > +        tcg_gen_lookup_and_goto_ptr();
> >       }
> >   }
> > @@ -4153,7 +4153,7 @@ static void disas_sparc_insn(DisasContext * dc, unsigned int 
> > insn)
> >                                   /* End TB to notice changed ASI.  */
> >                                   save_state(dc);
> >                                   gen_op_next_insn();
> > -                                tcg_gen_exit_tb(NULL, 0);
> > +                                tcg_gen_lookup_and_goto_ptr();
> >                                   dc->base.is_jmp = DISAS_NORETURN;
> >                                   break;
> >                               case 0x6: /* V9 wrfprs */
> > @@ -4162,7 +4162,7 @@ static void disas_sparc_insn(DisasContext * dc, unsigned int 
> > insn)
> >                                   dc->fprs_dirty = 0;
> >                                   save_state(dc);
> >                                   gen_op_next_insn();
> > -                                tcg_gen_exit_tb(NULL, 0);
> > +                                tcg_gen_lookup_and_goto_ptr();
> >                                   dc->base.is_jmp = DISAS_NORETURN;
> >                                   break;
> >                               case 0xf: /* V9 sir, nop if user */
> > @@ -5661,7 +5661,7 @@ static void sparc_tr_tb_stop(DisasContextBase *dcbase, 
> > CPUState *cs)
> >                   tcg_gen_movi_tl(cpu_pc, dc->pc);
> >               }
> >               save_npc(dc);
> > -            tcg_gen_exit_tb(NULL, 0);
> > +            tcg_gen_lookup_and_goto_ptr();
> >           }
> >           break;

Obviously nothing notionally against this patch, however if you could give me a few 
days to run my OpenBIOS SPARC32/SPARC64 boot tests against git master with this patch 
applied to double-check there are no regressions, that would be great.


ATB,

Mark.