|
| From: | Thomas Huth |
| Subject: | Re: [PATCH v10 1/8] memory: prevent dma-reentracy issues |
| Date: | Thu, 11 May 2023 10:58:22 +0200 |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 |
On 11/05/2023 10.53, Song Gao wrote: ...
And
Should we need add ' @skipIf(os.getenv('GITLAB_CI'), 'Running on GitLab')' ?
I see some tests add this.
No, please don't add that unless there is a good reason. That marker is only required if the test does not work reliable on gitlab, e.g. if it sometimes fails due to race conditions or if it takes incredibly long to finish.
Thomas
| [Prev in Thread] | Current Thread | [Next in Thread] |