Re: [PATCH 3/3] migration: Make dirtyrate.c target independent

[Richard Henderson]

On 5/11/23 12:46, Juan Quintela wrote:
> > > +softmmu_ss.add(when: 'CONFIG_SOFTMMU', if_true: files('dirtyrate.c'))
> >
> > This becomes
> >
> > softmmu_ss.add(files('dirtyrate.c'))
> >
> > the when: is redundant with 'softmmu_ss'.
>
> It looked weird, but I didn't understand this stuff well enough, so I
> just copyed what was there O:-)
>
> Is there any documentation about this?  Because what I usually do is
> search for a file that does (more or less) the same that I need and just
> add it to that list.

It's just top-level make^H^H^H^Hmeson.build related.

We have

common_ss.add_all(when: 'CONFIG_SOFTMMU', if_true: [softmmu_ss])

so everything in softmmu_ss is already protected by CONFIG_SOFTMMU.


r~