Re: [PATCH 07/27] mkvenv: add diagnose() method for ensure() failures

[John Snow]

On Thu, May 11, 2023, 11:57 AM Paolo Bonzini <pbonzini@redhat.com> wrote:

Il gio 11 mag 2023, 17:53 John Snow <jsnow@redhat.com> ha scritto:

You're right, in the "optional" case for sphinx the error isn't really *that* bad or serious. I'll try to work this or something very similar to it in.

I was thinking it could be up to the caller to discard the input, but I suppose we can also route the semantics down into the tool, too.

I'll play with it.

If you think that what I posted is okay or at least a start, I can squash it in.

Paolo

I didn't want to bet that there wouldn't be more feedback 😅

but, you can squash it in pre-emptively and I'll do the same and we'll just see what happens.

--js