Re: [PATCH 27/27] mkvenv.py: experiment; use distlib to generate script

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 27/27] mkvenv.py: experiment; use distlib to generate script

From:	Paolo Bonzini
Subject:	Re: [PATCH 27/27] mkvenv.py: experiment; use distlib to generate script entry points
Date:	Thu, 11 May 2023 18:14:10 +0200

Il gio 11 mag 2023, 17:58 John Snow <jsnow@redhat.com> ha scritto:

I'll make that simplifying change, which will also allow me to just put the import in the global scope instead of trying to do it JIT to work around ensurepip shenanigans. Should be a few less "I know this is bad" comments for the linters, too.

I don't think you can do that because, until you are running in the new venv, you aren't guaranteed to have either distlib or pip. Once in the venv you'll get the latter via ensurepip, if it wasn't already present in the system site-packages.

Paolo

--js

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH 21/27] configure: bootstrap sphinx with mkvenv, (continued)
- [PATCH 21/27] configure: bootstrap sphinx with mkvenv, John Snow, 2023/05/10
- [PATCH 23/27] Python: Drop support for Python 3.6, John Snow, 2023/05/10
- [PATCH 22/27] configure: add --enable-pypi and --disable-pypi, John Snow, 2023/05/10
- [PATCH 25/27] mkvenv: mark command as required, John Snow, 2023/05/10
- [PATCH 24/27] configure: Add courtesy hint to Python version failure message, John Snow, 2023/05/10
- [PATCH 26/27] python: bump some of the dependencies, John Snow, 2023/05/10
- [PATCH 27/27] mkvenv.py: experiment; use distlib to generate script entry points, John Snow, 2023/05/10
  - Re: [PATCH 27/27] mkvenv.py: experiment; use distlib to generate script entry points, Paolo Bonzini, 2023/05/11
  - Re: [PATCH 27/27] mkvenv.py: experiment; use distlib to generate script entry points, Paolo Bonzini, 2023/05/11
    - Re: [PATCH 27/27] mkvenv.py: experiment; use distlib to generate script entry points, John Snow, 2023/05/11
    - Re: [PATCH 27/27] mkvenv.py: experiment; use distlib to generate script entry points, Paolo Bonzini <=
    - Re: [PATCH 27/27] mkvenv.py: experiment; use distlib to generate script entry points, John Snow, 2023/05/11
- [PATCH 16/27] python/wheels: add vendored meson package, John Snow, 2023/05/10

Prev by Date: Re: [PATCH 13/84] tcg: Remove TCGv from tcg_gen_atomic_*
Next by Date: Re: [RFC PATCH 0/3] QEMU ACPI generic port support
Previous by thread: Re: [PATCH 27/27] mkvenv.py: experiment; use distlib to generate script entry points
Next by thread: Re: [PATCH 27/27] mkvenv.py: experiment; use distlib to generate script entry points
Index(es):
- Date
- Thread