Re: [PATCH 12/20] target/arm: Convert Extract instructions to decodetree

[Richard Henderson]

On 5/12/23 15:40, Peter Maydell wrote:
> +# Extract
> +
> +&extract        rd rn rm imm sf
> +@extract_64     1 .. ...... 1 . rm:5 imm:6 rn:5 rd:5      &extract sf=1
> +@extract_32     0 .. ...... 0 . rm:5 0 imm:5 rn:5 rd:5    &extract sf=0
> +
> +EXTR            . 00 100111 . 0 ..... ...... ..... ..... @extract_64
> +EXTR            . 00 100111 . 0 ..... ...... ..... ..... @extract_32

When there's exactly one use of the @format, it might be clearer to just merge 
the two

EXTR     1 00 100111 1 0 rm:5 imm:6 rn:5 rd:5  &extract sf=1


Either way,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~