Re: [PATCH 20/20] target/arm: Convert ERET, ERETAA, ERETAB to decodetree

[Richard Henderson]

On 5/12/23 15:41, Peter Maydell wrote:
> +static bool trans_ERETA(DisasContext *s, arg_reta *a)
> +{
> +    TCGv_i64 dst;
> +
> +    if (!dc_isar_feature(aa64_pauth, s)) {
> +        return false;
> +    }
> +    /* The FGT trap takes precedence over an auth trap. */
> +    if (s->fgt_eret) {
> +        gen_exception_insn_el(s, 0, EXCP_UDEF, a->m ? 3 : 2, 2);
> +        return true;
> +    }

Missing el0 exception, before fgt trap.

Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~