qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 06/12] simpletrace: Simplify construction of tracing metho


From: Mads Ynddal
Subject: Re: [PATCH v2 06/12] simpletrace: Simplify construction of tracing methods
Date: Mon, 15 May 2023 10:11:16 +0200

> 
> This is nice but breaking existing analysis scripts should be avoided.
> 
> I suggest preserving the Analyzer class the way it is and adding a new
> Analyzer2 class that follows the new method signature for trace event
> methods.

You're right. This has too large effects on the API.

I could go along with adding an Analyzer2 class. Should we mark Analyzer as
deprecated then? We could make __init__ emit a warning, and say new features are
only added to Analyzer2, but not put an exact EOL-date on Analyzer. I would
rather not maintain two parallel implementations of the same.

Let me know what you think.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]