[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 8/8] migration: Introduced MigrateChannelList struct to mi
|
From: |
Juan Quintela |
|
Subject: |
Re: [PATCH v4 8/8] migration: Introduced MigrateChannelList struct to migration code flow. |
|
Date: |
Mon, 15 May 2023 12:04:08 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) |
Het Gala <het.gala@nutanix.com> wrote:
> Integrated MigrateChannelList with all transport backends (socket, exec
> and rdma) for both source and destination migration code flow.
>
> Suggested-by: Aravind Retnakaran <aravind.retnakaran@nutanix.com>
> Signed-off-by: Het Gala <het.gala@nutanix.com>
Nothing especially wrong appears here, will wait for 2nd submission with
the previous fixes done (specially the local_error bits).
And in another order of events, you are not changing
tests/qtest/migration-test.c
My suggestion will be that for things that have more than one test
(i.e. tcp/unix/...) just change some of them to use the new syntax for
channels.
What do you think?
Later, Juan.
- [PATCH v4 4/8] migration: converts rdma backend to accept MigrateAddress struct, (continued)
[PATCH v4 7/8] migration: modified 'migrate-incoming' QAPI to accept 'channels' argument for migration., Het Gala, 2023/05/12
[PATCH v4 8/8] migration: Introduced MigrateChannelList struct to migration code flow., Het Gala, 2023/05/12
Re: [PATCH v4 0/8] migration: Modified 'migrate' and 'migrate-incoming' QAPI commands for migration, Markus Armbruster, 2023/05/16