Re: [PATCH v4 1/8] migration: introduced 'MigrateAddress' in QAPI for migration wire protocol.

[Daniel P . Berrangé]

On Fri, May 12, 2023 at 02:32:33PM +0000, Het Gala wrote:
> This patch introduces well defined MigrateAddress struct and its related child
> objects.
> 
> The existing argument of 'migrate' and 'migrate-incoming' QAPI - 'uri' is of
> string type. The current migration flow follows double encoding scheme for
> fetching migration parameters such as 'uri' and this is not an ideal design.
> 
> Motive for intoducing struct level design is to prevent double encoding of 
> QAPI
> arguments, as Qemu should be able to directly use the QAPI arguments without
> any level of encoding.
> 
> Suggested-by: Aravind Retnakaran <aravind.retnakaran@nutanix.com>
> Signed-off-by: Het Gala <het.gala@nutanix.com>
> ---
>  qapi/migration.json | 41 +++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 41 insertions(+)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|