[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] hw/arm/sbsa-ref: add GIC node into DT
|
From: |
Marcin Juszkiewicz |
|
Subject: |
Re: [PATCH] hw/arm/sbsa-ref: add GIC node into DT |
|
Date: |
Mon, 15 May 2023 12:21:59 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 |
W dniu 15.05.2023 o 12:15, Peter Maydell pisze:> On Mon, 15 May 2023 at
11:04, Marcin Juszkiewicz
> <marcin.juszkiewicz@linaro.org> wrote:
>>
>> Let add GIC information into DeviceTree as part of SBSA-REF versioning.
>>
>> Trusted Firmware will read it and provide to next firmware level.
>>
>> Bumps platform version to 0.1 one so we can check is node is present.
>
> (Missing signed-off-by.)
Oops. Will add in next revision.
> I thought the idea with the sbsa-ref dtb was that it was
> really just a minimal provision of data to the firmware,
> not a real DTB, and that (as on real hardware) creating
> the DTB to pass to the next level of the guest code was
> the job of the guest firmware.
>
> Why do we need to provide a full GIC DTB node ?
First version had "/magic-numbers/gicd.base" node when I was checking
will it work as expected. Then there was discussion about making it
proper DT node to avoid "DT has schema for it" replies.
I took code from arm/hw/virt.c for it.