[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] sbsa-ref: switch default cpu core to Neoverse-N1
|
From: |
Peter Maydell |
|
Subject: |
Re: [PATCH] sbsa-ref: switch default cpu core to Neoverse-N1 |
|
Date: |
Mon, 15 May 2023 16:28:00 +0100 |
On Fri, 12 May 2023 at 17:02, Leif Lindholm <quic_llindhol@quicinc.com> wrote:
>
> On 2023-05-12 15:50, Peter Maydell wrote:
> > On Sat, 6 May 2023 at 19:34, Marcin Juszkiewicz
> > <marcin.juszkiewicz@linaro.org> wrote:
> >>
> >> The world outside moves to newer and newer cpu cores. Let move SBSA
> >> Reference Platform to something newer as well.
> >>
> >> Signed-off-by: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
> >> ---
> >> hw/arm/sbsa-ref.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/hw/arm/sbsa-ref.c b/hw/arm/sbsa-ref.c
> >> index 0b93558dde..a1562f944a 100644
> >> --- a/hw/arm/sbsa-ref.c
> >> +++ b/hw/arm/sbsa-ref.c
> >> @@ -852,7 +852,7 @@ static void sbsa_ref_class_init(ObjectClass *oc, void
> >> *data)
> >>
> >> mc->init = sbsa_ref_init;
> >> mc->desc = "QEMU 'SBSA Reference' ARM Virtual Machine";
> >> - mc->default_cpu_type = ARM_CPU_TYPE_NAME("cortex-a57");
> >> + mc->default_cpu_type = ARM_CPU_TYPE_NAME("neoverse-n1");
> >> mc->max_cpus = 512;
> >> mc->pci_allow_0_address = true;
> >> mc->minimum_page_bits = 12;
> >
> > Seems reasonable; Leif, any objection?
>
> None.
>
> Longer-term, I still want to move to "max" as the default, but that is
> likely to require some invasive changes to TF-A, and this is already a
> huge improvement. So:
> Reviewed-by: Leif Lindholm <quic_llindhol@quicinc.com>
Thanks; applied to target-arm.next.
-- PMM