Re: [PATCH] lsi53c895a: disable reentrancy detection for MMIO region, too

[Alexander Bulekov]

On 230516 1105, Thomas Huth wrote:
> While trying to use a SCSI disk on the LSI controller with an
> older version of Fedora (25), I'm getting:
> 
>  qemu: warning: Blocked re-entrant IO on MemoryRegion: lsi-mmio at addr: 0x34

Do you have a gdb backtrace for this one or is there some easy way to
reproduce with just a LiveCD or something? Marking mmio_io re-entrancy
safe would bring back https://gitlab.com/qemu-project/qemu/-/issues/1563
Maybe there is some other workaround here?
-Alex

> 
> and the SCSI controller is not usable. Seems like we have to
> disable the reentrancy checker for the MMIO region, too, to
> get this working again.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  hw/scsi/lsi53c895a.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/hw/scsi/lsi53c895a.c b/hw/scsi/lsi53c895a.c
> index db27872963..048436352b 100644
> --- a/hw/scsi/lsi53c895a.c
> +++ b/hw/scsi/lsi53c895a.c
> @@ -2307,6 +2307,7 @@ static void lsi_scsi_realize(PCIDevice *dev, Error 
> **errp)
>       * re-entrancy guard.
>       */
>      s->ram_io.disable_reentrancy_guard = true;
> +    s->mmio_io.disable_reentrancy_guard = true;
>  
>      address_space_init(&s->pci_io_as, pci_address_space_io(dev), 
> "lsi-pci-io");
>      qdev_init_gpio_out(d, &s->ext_irq, 1);
> -- 
> 2.31.1
>