[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 5/5] gitlab: support disabling job auto-run in upstream
|
From: |
Daniel P . Berrangé |
|
Subject: |
Re: [PATCH 5/5] gitlab: support disabling job auto-run in upstream |
|
Date: |
Wed, 17 May 2023 16:38:44 +0100 |
|
User-agent: |
Mutt/2.2.9 (2022-11-12) |
On Wed, May 17, 2023 at 06:13:44PM +0300, Michael Tokarev wrote:
> 17.05.2023 16:54, Daniel P. Berrangé wrote:
> > In forks QEMU_CI=1 can be used to create a pipeline but not auto-run any
> > jobs. In upstream jobs always auto-run, which is equiv of QEMU_CI=2.
> >
> > This supports setting QEMU_CI=1 in upstream, to disable job auto-run.
> > This can be used to preserve CI minutes if repushing a branch to staging
> > with a specific fix that only needs testing in limited scenarios.
> >
> > Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> > ---
> > .gitlab-ci.d/base.yml | 10 ++++++++++
> > 1 file changed, 10 insertions(+)
> >
> > diff --git a/.gitlab-ci.d/base.yml b/.gitlab-ci.d/base.yml
> > index 999149852e..188a770799 100644
> > --- a/.gitlab-ci.d/base.yml
> > +++ b/.gitlab-ci.d/base.yml
> > @@ -109,6 +109,16 @@ variables:
> > - if: '$QEMU_CI != "2" && $CI_PROJECT_NAMESPACE != $QEMU_CI_UPSTREAM'
> > when: manual
> > + # Upstream pipeline jobs start automatically unless told not to
> > + # by setting QEMU_CI=1
> > + - if: '$QEMU_CI == "1" && $CI_PROJECT_NAMESPACE == $QEMU_CI_UPSTREAM
> > && $CI_COMMIT_BRANCH =~ /staging-[[:digit:]]+\.[[:digit:]]/'
>
> Should this be enabled for main staging branch too?
> I dunno how it is useful though.
Yes, actually it should have been. There's no downside to enabling it for
'staging' too, since it is opt-in.
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- [PATCH 0/5] gitlab: improvements to handling of stable staging branches, Daniel P . Berrangé, 2023/05/17
- [PATCH 2/5] gitlab: allow overriding name of the upstream repository, Daniel P . Berrangé, 2023/05/17
- [PATCH 4/5] gitlab: avoid extra pipelines for tags and stable branches, Daniel P . Berrangé, 2023/05/17
- [PATCH 5/5] gitlab: support disabling job auto-run in upstream, Daniel P . Berrangé, 2023/05/17
- [PATCH 3/5] gitlab: stable staging branches publish containers in a separate tag, Daniel P . Berrangé, 2023/05/17
- [PATCH 1/5] gitlab: centralize the container tag name, Daniel P . Berrangé, 2023/05/17