qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/5] gitlab: centralize the container tag name


From: Richard Henderson
Subject: Re: [PATCH 1/5] gitlab: centralize the container tag name
Date: Wed, 17 May 2023 13:01:45 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0

On 5/17/23 06:54, Daniel P. Berrangé wrote:
We use a fixed container tag of 'latest' so that contributors' forks
don't end up with an ever growing number of containers as they work
on throwaway feature branches.

This fixed tag causes problems running CI upstream in stable staging
branches, however, because the stable staging branch will publish old
container content that clashes with that needed by primary staging
branch. This makes it impossible to reliably run CI pipelines in
parallel in upstream for different staging branches.

This introduces $QEMU_CI_CONTAINER_TAG global variable as a way to
change which tag container publishing uses. Initially it can be set
by contributors as a git push option if they want to override the
default use of 'latest' eg

   git push gitlab <branch> -o ci.variable=QEMU_CONTAINER_TAG=fish

this is useful if contributors need to run pipelines for different
branches concurrently in their forks.

Signed-off-by: Daniel P. Berrangé<berrange@redhat.com>
---
  .gitlab-ci.d/base.yml                | 6 ++++++
  .gitlab-ci.d/buildtest-template.yml  | 4 ++--
  .gitlab-ci.d/buildtest.yml           | 4 ++--
  .gitlab-ci.d/container-template.yml  | 3 ++-
  .gitlab-ci.d/crossbuild-template.yml | 6 +++---
  .gitlab-ci.d/static_checks.yml       | 4 ++--
  docs/devel/ci-jobs.rst.inc           | 5 +++++
  7 files changed, 22 insertions(+), 10 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]