qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 5/9] util/bufferiszero: Use i386 cpuinfo.h


From: Juan Quintela
Subject: Re: [PATCH 5/9] util/bufferiszero: Use i386 cpuinfo.h
Date: Thu, 18 May 2023 11:49:11 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)

Richard Henderson <richard.henderson@linaro.org> wrote:
> Use cpuinfo_init() during init_accel(), and the variable cpuinfo
> during test_buffer_is_zero_next_accel().  Adjust the logic that
> cycles through the set of accelerators for testing.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>

Semi related to this.

For migration, I check every single page to see if it is full of zeros.
But I can promisse that it is just a page (i.e. 4KiB, 16KiB or 64KiB,
correct alignation, correct length, ...).

Will do it make sense to have an special function for that?

Yes, I have found with perf that bufferiszero() is quite high.  No, I
haven't try to experiment using a function that is optimized for the
page size in the architecture.

What do you think?

Later, Juan.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]