[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 5/5] migration: restore vmstate on migration failure
|
From: |
Juan Quintela |
|
Subject: |
Re: [PATCH 5/5] migration: restore vmstate on migration failure |
|
Date: |
Thu, 18 May 2023 13:22:11 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) |
Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru> wrote:
> 1. Otherwise failed migration just drops guest-panicked state, which is
> not good for management software.
>
> 2. We do keep different paused states like guest-panicked during
> migration with help of global_state state.
>
> 3. We do restore running state on source when migration is cancelled or
> failed.
>
> 4. "postmigrate" state is documented as "guest is paused following a
> successful 'migrate'", so originally it's only for successful path
> and we never documented current behavior.
>
> Let's restore paused states like guest-panicked in case of cancel or
> fail too. Allow same transitions like for inmigrate state.
>
> This commit changes the behavior that was introduced by commit
> 42da5550d6 "migration: set state to post-migrate on failure" and
> provides a bit different fix on related
> https://bugzilla.redhat.com/show_bug.cgi?id=1355683
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Reviewed-by: Juan Quintela <quintela@redhat.com>
- [PATCH 1/5] runstate: add runstate_get(), (continued)
- [PATCH 1/5] runstate: add runstate_get(), Vladimir Sementsov-Ogievskiy, 2023/05/17
- [PATCH 2/5] migration: never fail in global_state_store(), Vladimir Sementsov-Ogievskiy, 2023/05/17
- [PATCH 4/5] migration: switch from .vm_was_running to .vm_old_state, Vladimir Sementsov-Ogievskiy, 2023/05/17
- [PATCH 3/5] runstate: drop unused runstate_store(), Vladimir Sementsov-Ogievskiy, 2023/05/17
- [PATCH 5/5] migration: restore vmstate on migration failure, Vladimir Sementsov-Ogievskiy, 2023/05/17
- Re: [PATCH 5/5] migration: restore vmstate on migration failure,
Juan Quintela <=
- Re: [PATCH 0/5] Restore vmstate on cancelled/failed migration, Juan Quintela, 2023/05/18