qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/6] meson: simplify logic for -Dfdt


From: Daniel P . Berrangé
Subject: Re: [PATCH 2/6] meson: simplify logic for -Dfdt
Date: Fri, 19 May 2023 10:04:37 +0100
User-agent: Mutt/2.2.9 (2022-11-12)

On Fri, May 19, 2023 at 10:56:42AM +0200, Paolo Bonzini wrote:
> fdt_opt == 'disabled' is going to give an error if libfdt is required
> by any target, so catch that immediately.  For fdt_opt == 'enabled',
> instead, do not check immediately whether the internal libfdt is present.
> Instead do the check after ascertaining that libfdt is absent or too old.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  meson.build | 29 ++++++++++++++++-------------
>  1 file changed, 16 insertions(+), 13 deletions(-)


Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|




reply via email to

[Prev in Thread] Current Thread [Next in Thread]