qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 0/2] hw/cxl: CDAT file handling fixes.


From: Michael Tokarev
Subject: Re: [PATCH 0/2] hw/cxl: CDAT file handling fixes.
Date: Sat, 20 May 2023 07:46:16 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0

21.04.2023 16:20, Jonathan Cameron via wrote:
I've picked up Hao Zeng's v5 and added a patch to deal with the
issues that Peter pointed out in this area.

On error, the CDAT file handling left resource dangling and didn't
cleanly exit from calling functions.  Hao Zeng dealt with closing
the file. The second patch deals with the buffer allocation and
ensuring a clean exit at the two callers.

Hao Zeng (1):
   hw/cxl: cdat: Fix open file not closed in ct3_load_cdat()

Jonathan Cameron (1):
   hw/cxl: cdat: Fix failure to free buffer in erorr paths

  hw/cxl/cxl-cdat.c            | 60 +++++++++++++++---------------------
  hw/mem/cxl_type3.c           |  4 +++
  hw/pci-bridge/cxl_upstream.c |  3 ++
  3 files changed, 32 insertions(+), 35 deletions(-)

Hi!

Is it a stable (8.0 & 7.2) material?
The issues does not seem to be very important, still smells like
a good thing to have in -stable.

Thanks,

/mjt



reply via email to

[Prev in Thread] Current Thread [Next in Thread]