Re: [PATCH 2/2] hw/mips/loongson3_virt: Remove CPU restrictions for TCG

[Philippe Mathieu-Daudé]

On 21/5/23 23:48, Jiaxun Yang wrote:
> After implemented CPUCFG and CSR, we are now able to boot Linux
> kernel with Loongson-3A4000 CPU, so there is no point to restrict
> CPU type for TCG.
>
> Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
> ---
>   hw/mips/loongson3_virt.c | 4 ----
>   1 file changed, 4 deletions(-)
>
> diff --git a/hw/mips/loongson3_virt.c b/hw/mips/loongson3_virt.c
> index a57245012598..47289fb6bf85 100644
> --- a/hw/mips/loongson3_virt.c
> +++ b/hw/mips/loongson3_virt.c
> @@ -488,10 +488,6 @@ static void mips_loongson3_virt_init(MachineState *machine)
>           if (!machine->cpu_type) {
>               machine->cpu_type = MIPS_CPU_TYPE_NAME("Loongson-3A1000");
>           }
> -        if (!strstr(machine->cpu_type, "Loongson-3A1000")) {
> -            error_report("Loongson-3/TCG needs cpu type Loongson-3A1000");

Hmm, shouldn't we check for CPUs supporting the INSN_LOONGSON3A
insn_flags at least?

> -            exit(1);
> -        }
>       } else {
>           if (!machine->cpu_type) {
>               machine->cpu_type = MIPS_CPU_TYPE_NAME("Loongson-3A4000");