[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 13/20] tests/qtest/cdrom-test: Fix the test to also work without o
|
From: |
Thomas Huth |
|
Subject: |
[PULL 13/20] tests/qtest/cdrom-test: Fix the test to also work without optional devices |
|
Date: |
Mon, 22 May 2023 13:50:07 +0200 |
It's possible to disable virtio-scsi and virtio-blk in the binaries,
so we must not run the corresponding tests if these devices are missing.
Message-Id: <20230512124033.502654-14-thuth@redhat.com>
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
tests/qtest/cdrom-test.c | 16 +++++++++++++---
1 file changed, 13 insertions(+), 3 deletions(-)
diff --git a/tests/qtest/cdrom-test.c b/tests/qtest/cdrom-test.c
index 2b7e10d920..d1cc375849 100644
--- a/tests/qtest/cdrom-test.c
+++ b/tests/qtest/cdrom-test.c
@@ -136,9 +136,12 @@ static void add_x86_tests(void)
}
qtest_add_data_func("cdrom/boot/default", "-cdrom ", test_cdboot);
- qtest_add_data_func("cdrom/boot/virtio-scsi",
- "-device virtio-scsi -device scsi-cd,drive=cdr "
- "-blockdev file,node-name=cdr,filename=", test_cdboot);
+ if (qtest_has_device("virtio-scsi-ccw")) {
+ qtest_add_data_func("cdrom/boot/virtio-scsi",
+ "-device virtio-scsi -device scsi-cd,drive=cdr "
+ "-blockdev file,node-name=cdr,filename=",
+ test_cdboot);
+ }
/*
* Unstable CI test under load
* See https://lists.gnu.org/archive/html/qemu-devel/2019-02/msg05509.html
@@ -183,10 +186,17 @@ static void add_s390x_tests(void)
{
if (!qtest_has_accel("tcg") && !qtest_has_accel("kvm")) {
g_test_skip("No KVM or TCG accelerator available, skipping boot
tests");
+ }
+ if (!qtest_has_device("virtio-blk-ccw")) {
return;
}
qtest_add_data_func("cdrom/boot/default", "-cdrom ", test_cdboot);
+
+ if (!qtest_has_device("virtio-scsi-ccw")) {
+ return;
+ }
+
qtest_add_data_func("cdrom/boot/virtio-scsi",
"-device virtio-scsi -device scsi-cd,drive=cdr "
"-blockdev file,node-name=cdr,filename=", test_cdboot);
--
2.31.1
- [PULL 03/20] hw: Move the default NIC machine class setting from the x86 to the generic one, (continued)
- [PULL 03/20] hw: Move the default NIC machine class setting from the x86 to the generic one, Thomas Huth, 2023/05/22
- [PULL 07/20] hw/sh4: Use MachineClass->default_nic in the sh4 r2d machine, Thomas Huth, 2023/05/22
- [PULL 05/20] hw/ppc: Use MachineClass->default_nic in the ppc machines, Thomas Huth, 2023/05/22
- [PULL 11/20] tests/qtest/readconfig-test: Check for the availability of USB controllers, Thomas Huth, 2023/05/22
- [PULL 08/20] hw/char/parallel: Move TYPE_ISA_PARALLEL to the header file, Thomas Huth, 2023/05/22
- [PULL 09/20] hw/i386: Ignore the default parallel port if it has not been compiled into QEMU, Thomas Huth, 2023/05/22
- [PULL 06/20] hw/s390x: Use MachineClass->default_nic in the s390x machine, Thomas Huth, 2023/05/22
- [PULL 17/20] tests/qemu-iotests/172: Run QEMU with -vga none and -nic none, Thomas Huth, 2023/05/22
- [PULL 16/20] tests/qtest/meson.build: Run the net filter tests only with default devices, Thomas Huth, 2023/05/22
- [PULL 20/20] memory: stricter checks prior to unsetting engaged_in_io, Thomas Huth, 2023/05/22
- [PULL 13/20] tests/qtest/cdrom-test: Fix the test to also work without optional devices,
Thomas Huth <=
- [PULL 10/20] hw/sparc64/sun4u: Use MachineClass->default_nic and MachineClass->no_parallel, Thomas Huth, 2023/05/22
- [PULL 19/20] acpi/tests/avocado/bits: enable bios bits avocado tests on gitlab CI pipeline, Thomas Huth, 2023/05/22
- [PULL 18/20] .gitlab-ci.d/buildtest.yml: Run full "make check" with --without-default-devices, Thomas Huth, 2023/05/22
- [PULL 14/20] tests/qtest/virtio-ccw-test: Remove superfluous tests, Thomas Huth, 2023/05/22
- [PULL 02/20] softmmu/vl.c: Check for the availability of the VGA device before using it, Thomas Huth, 2023/05/22
- [PULL 12/20] tests/qtest/usb-hcd-uhci-test: Skip test if UHCI controller is not available, Thomas Huth, 2023/05/22
- [PULL 15/20] tests/qtest: Check for the availability of virtio-ccw devices before using them, Thomas Huth, 2023/05/22
- Re: [PULL 00/20] Allow "make check" with "--without-default-devices", Richard Henderson, 2023/05/22