[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 14/20] tests/qtest/virtio-ccw-test: Remove superfluous tests
|
From: |
Thomas Huth |
|
Subject: |
[PULL 14/20] tests/qtest/virtio-ccw-test: Remove superfluous tests |
|
Date: |
Mon, 22 May 2023 13:50:08 +0200 |
virtio-balloon-ccw is already tested in the device-plug-test,
virtio-blk-ccw is already tested in cdrom-test, and virtio-net-ccw
is already tested in the pxe-test, so there is not much point
in doing "nop" tests here again.
Message-Id: <20230512124033.502654-15-thuth@redhat.com>
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
tests/qtest/virtio-ccw-test.c | 23 -----------------------
1 file changed, 23 deletions(-)
diff --git a/tests/qtest/virtio-ccw-test.c b/tests/qtest/virtio-ccw-test.c
index 2de77bb6fe..c0790e3ba2 100644
--- a/tests/qtest/virtio-ccw-test.c
+++ b/tests/qtest/virtio-ccw-test.c
@@ -17,12 +17,6 @@
#include "libqtest-single.h"
#include "libqos/virtio.h"
-static void virtio_balloon_nop(void)
-{
- global_qtest = qtest_initf("-device virtio-balloon-ccw");
- qtest_end();
-}
-
static void virtconsole_nop(void)
{
global_qtest = qtest_initf("-device virtio-serial-ccw,id=vser0 "
@@ -53,20 +47,6 @@ static void virtio_serial_hotplug(void)
qtest_quit(qts);
}
-static void virtio_blk_nop(void)
-{
- global_qtest = qtest_initf("-drive if=none,id=drv0,file=null-co://,"
- "file.read-zeroes=on,format=raw "
- "-device virtio-blk-ccw,drive=drv0");
- qtest_end();
-}
-
-static void virtio_net_nop(void)
-{
- global_qtest = qtest_initf("-device virtio-net-ccw");
- qtest_end();
-}
-
static void virtio_rng_nop(void)
{
global_qtest = qtest_initf("-device virtio-rng-ccw");
@@ -96,13 +76,10 @@ static void virtio_scsi_hotplug(void)
int main(int argc, char **argv)
{
g_test_init(&argc, &argv, NULL);
- qtest_add_func("/virtio/balloon/nop", virtio_balloon_nop);
qtest_add_func("/virtio/console/nop", virtconsole_nop);
qtest_add_func("/virtio/serialport/nop", virtserialport_nop);
qtest_add_func("/virtio/serial/nop", virtio_serial_nop);
qtest_add_func("/virtio/serial/hotplug", virtio_serial_hotplug);
- qtest_add_func("/virtio/block/nop", virtio_blk_nop);
- qtest_add_func("/virtio/net/nop", virtio_net_nop);
qtest_add_func("/virtio/rng/nop", virtio_rng_nop);
qtest_add_func("/virtio/scsi/nop", virtio_scsi_nop);
qtest_add_func("/virtio/scsi/hotplug", virtio_scsi_hotplug);
--
2.31.1
- [PULL 08/20] hw/char/parallel: Move TYPE_ISA_PARALLEL to the header file, (continued)
- [PULL 08/20] hw/char/parallel: Move TYPE_ISA_PARALLEL to the header file, Thomas Huth, 2023/05/22
- [PULL 09/20] hw/i386: Ignore the default parallel port if it has not been compiled into QEMU, Thomas Huth, 2023/05/22
- [PULL 06/20] hw/s390x: Use MachineClass->default_nic in the s390x machine, Thomas Huth, 2023/05/22
- [PULL 17/20] tests/qemu-iotests/172: Run QEMU with -vga none and -nic none, Thomas Huth, 2023/05/22
- [PULL 16/20] tests/qtest/meson.build: Run the net filter tests only with default devices, Thomas Huth, 2023/05/22
- [PULL 20/20] memory: stricter checks prior to unsetting engaged_in_io, Thomas Huth, 2023/05/22
- [PULL 13/20] tests/qtest/cdrom-test: Fix the test to also work without optional devices, Thomas Huth, 2023/05/22
- [PULL 10/20] hw/sparc64/sun4u: Use MachineClass->default_nic and MachineClass->no_parallel, Thomas Huth, 2023/05/22
- [PULL 19/20] acpi/tests/avocado/bits: enable bios bits avocado tests on gitlab CI pipeline, Thomas Huth, 2023/05/22
- [PULL 18/20] .gitlab-ci.d/buildtest.yml: Run full "make check" with --without-default-devices, Thomas Huth, 2023/05/22
- [PULL 14/20] tests/qtest/virtio-ccw-test: Remove superfluous tests,
Thomas Huth <=
- [PULL 02/20] softmmu/vl.c: Check for the availability of the VGA device before using it, Thomas Huth, 2023/05/22
- [PULL 12/20] tests/qtest/usb-hcd-uhci-test: Skip test if UHCI controller is not available, Thomas Huth, 2023/05/22
- [PULL 15/20] tests/qtest: Check for the availability of virtio-ccw devices before using them, Thomas Huth, 2023/05/22
- Re: [PULL 00/20] Allow "make check" with "--without-default-devices", Richard Henderson, 2023/05/22