[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 15/20] tests/qtest: Check for the availability of virtio-ccw devic
|
From: |
Thomas Huth |
|
Subject: |
[PULL 15/20] tests/qtest: Check for the availability of virtio-ccw devices before using them |
|
Date: |
Mon, 22 May 2023 13:50:09 +0200 |
The devices might not have been compiled into the QEMU binary, so we
have to check before we can use them.
Message-Id: <20230512124033.502654-16-thuth@redhat.com>
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
tests/qtest/device-plug-test.c | 9 ++++++++-
tests/qtest/virtio-ccw-test.c | 20 +++++++++++++-------
2 files changed, 21 insertions(+), 8 deletions(-)
diff --git a/tests/qtest/device-plug-test.c b/tests/qtest/device-plug-test.c
index 01cecd6e20..abd544b70c 100644
--- a/tests/qtest/device-plug-test.c
+++ b/tests/qtest/device-plug-test.c
@@ -156,7 +156,14 @@ static void test_q35_pci_unplug_json_request(void)
static void test_ccw_unplug(void)
{
- QTestState *qtest = qtest_initf("-device virtio-balloon-ccw,id=dev0");
+ QTestState *qtest;
+
+ if (!qtest_has_device("virtio-balloon-ccw")) {
+ g_test_skip("Device virtio-balloon-ccw not available");
+ return;
+ }
+
+ qtest = qtest_initf("-device virtio-balloon-ccw,id=dev0");
qtest_qmp_device_del_send(qtest, "dev0");
wait_device_deleted_event(qtest, "dev0");
diff --git a/tests/qtest/virtio-ccw-test.c b/tests/qtest/virtio-ccw-test.c
index c0790e3ba2..f4f5858b84 100644
--- a/tests/qtest/virtio-ccw-test.c
+++ b/tests/qtest/virtio-ccw-test.c
@@ -76,13 +76,19 @@ static void virtio_scsi_hotplug(void)
int main(int argc, char **argv)
{
g_test_init(&argc, &argv, NULL);
- qtest_add_func("/virtio/console/nop", virtconsole_nop);
- qtest_add_func("/virtio/serialport/nop", virtserialport_nop);
- qtest_add_func("/virtio/serial/nop", virtio_serial_nop);
- qtest_add_func("/virtio/serial/hotplug", virtio_serial_hotplug);
- qtest_add_func("/virtio/rng/nop", virtio_rng_nop);
- qtest_add_func("/virtio/scsi/nop", virtio_scsi_nop);
- qtest_add_func("/virtio/scsi/hotplug", virtio_scsi_hotplug);
+ if (qtest_has_device("virtio-serial-ccw")) {
+ qtest_add_func("/virtio/console/nop", virtconsole_nop);
+ qtest_add_func("/virtio/serialport/nop", virtserialport_nop);
+ qtest_add_func("/virtio/serial/nop", virtio_serial_nop);
+ qtest_add_func("/virtio/serial/hotplug", virtio_serial_hotplug);
+ }
+ if (qtest_has_device("virtio-rng-ccw")) {
+ qtest_add_func("/virtio/rng/nop", virtio_rng_nop);
+ }
+ if (qtest_has_device("virtio-rng-ccw")) {
+ qtest_add_func("/virtio/scsi/nop", virtio_scsi_nop);
+ qtest_add_func("/virtio/scsi/hotplug", virtio_scsi_hotplug);
+ }
return g_test_run();
}
--
2.31.1
- [PULL 17/20] tests/qemu-iotests/172: Run QEMU with -vga none and -nic none, (continued)
- [PULL 17/20] tests/qemu-iotests/172: Run QEMU with -vga none and -nic none, Thomas Huth, 2023/05/22
- [PULL 16/20] tests/qtest/meson.build: Run the net filter tests only with default devices, Thomas Huth, 2023/05/22
- [PULL 20/20] memory: stricter checks prior to unsetting engaged_in_io, Thomas Huth, 2023/05/22
- [PULL 13/20] tests/qtest/cdrom-test: Fix the test to also work without optional devices, Thomas Huth, 2023/05/22
- [PULL 10/20] hw/sparc64/sun4u: Use MachineClass->default_nic and MachineClass->no_parallel, Thomas Huth, 2023/05/22
- [PULL 19/20] acpi/tests/avocado/bits: enable bios bits avocado tests on gitlab CI pipeline, Thomas Huth, 2023/05/22
- [PULL 18/20] .gitlab-ci.d/buildtest.yml: Run full "make check" with --without-default-devices, Thomas Huth, 2023/05/22
- [PULL 14/20] tests/qtest/virtio-ccw-test: Remove superfluous tests, Thomas Huth, 2023/05/22
- [PULL 02/20] softmmu/vl.c: Check for the availability of the VGA device before using it, Thomas Huth, 2023/05/22
- [PULL 12/20] tests/qtest/usb-hcd-uhci-test: Skip test if UHCI controller is not available, Thomas Huth, 2023/05/22
- [PULL 15/20] tests/qtest: Check for the availability of virtio-ccw devices before using them,
Thomas Huth <=
- Re: [PULL 00/20] Allow "make check" with "--without-default-devices", Richard Henderson, 2023/05/22