[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v5 20/48] igb: Remove goto
|
From: |
Akihiko Odaki |
|
Subject: |
[PATCH v5 20/48] igb: Remove goto |
|
Date: |
Tue, 23 May 2023 11:43:11 +0900 |
The goto is a bit confusing as it changes the control flow only if L4
protocol is not recognized. It is also different from e1000e, and
noisy when comparing e1000e and igb.
Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Reviewed-by: Sriram Yagnaraman <sriram.yagnaraman@est.tech>
---
hw/net/igb_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c
index 946b917f91..bae51cbb63 100644
--- a/hw/net/igb_core.c
+++ b/hw/net/igb_core.c
@@ -1297,7 +1297,7 @@ igb_build_rx_metadata(IGBCore *core,
break;
default:
- goto func_exit;
+ break;
}
} else {
trace_e1000e_rx_metadata_l4_cso_disabled();
--
2.40.1
- [PATCH v5 10/48] Fix references to igb Avocado test, (continued)
- [PATCH v5 10/48] Fix references to igb Avocado test, Akihiko Odaki, 2023/05/22
- [PATCH v5 12/48] tests/avocado: Remove test_igb_nomsi_kvm, Akihiko Odaki, 2023/05/22
- [PATCH v5 11/48] tests/avocado: Remove unused imports, Akihiko Odaki, 2023/05/22
- [PATCH v5 14/48] net/eth: Rename eth_setup_vlan_headers_ex, Akihiko Odaki, 2023/05/22
- [PATCH v5 13/48] hw/net/net_tx_pkt: Remove net_rx_pkt_get_l4_info, Akihiko Odaki, 2023/05/22
- [PATCH v5 15/48] e1000x: Share more Rx filtering logic, Akihiko Odaki, 2023/05/22
- [PATCH v5 16/48] e1000x: Take CRC into consideration for size check, Akihiko Odaki, 2023/05/22
- [PATCH v5 17/48] e1000x: Rename TcpIpv6 into TcpIpv6Ex, Akihiko Odaki, 2023/05/22
- [PATCH v5 18/48] e1000e: Always log status after building rx metadata, Akihiko Odaki, 2023/05/22
- [PATCH v5 19/48] igb: Always log status after building rx metadata, Akihiko Odaki, 2023/05/22
- [PATCH v5 20/48] igb: Remove goto,
Akihiko Odaki <=
- [PATCH v5 22/48] e1000e: Reset packet state after emptying Tx queue, Akihiko Odaki, 2023/05/22
- [PATCH v5 21/48] igb: Read DCMD.VLE of the first Tx descriptor, Akihiko Odaki, 2023/05/22
- [PATCH v5 26/48] igb: Fix igb_mac_reg_init coding style alignment, Akihiko Odaki, 2023/05/22
- [PATCH v5 31/48] net/eth: Always add VLAN tag, Akihiko Odaki, 2023/05/22
- [PATCH v5 23/48] vmxnet3: Reset packet state after emptying Tx queue, Akihiko Odaki, 2023/05/22
- [PATCH v5 30/48] net/eth: Use void pointers, Akihiko Odaki, 2023/05/22
- [PATCH v5 24/48] igb: Add more definitions for Tx descriptor, Akihiko Odaki, 2023/05/22
- [PATCH v5 27/48] igb: Clear EICR bits for delayed MSI-X interrupts, Akihiko Odaki, 2023/05/22
- [PATCH v5 28/48] e1000e: Rename a variable in e1000e_receive_internal(), Akihiko Odaki, 2023/05/22
- [PATCH v5 29/48] igb: Rename a variable in igb_receive_internal(), Akihiko Odaki, 2023/05/22