[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 26/50] igb: Share common VF constants
|
From: |
Jason Wang |
|
Subject: |
[PULL 26/50] igb: Share common VF constants |
|
Date: |
Tue, 23 May 2023 15:32:14 +0800 |
From: Akihiko Odaki <akihiko.odaki@daynix.com>
The constants need to be consistent between the PF and VF.
Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Sriram Yagnaraman <sriram.yagnaraman@est.tech>
Signed-off-by: Jason Wang <jasowang@redhat.com>
---
hw/net/igb.c | 10 +++++-----
hw/net/igb_common.h | 8 ++++++++
hw/net/igbvf.c | 7 -------
3 files changed, 13 insertions(+), 12 deletions(-)
diff --git a/hw/net/igb.c b/hw/net/igb.c
index 51a7e91..1c989d7 100644
--- a/hw/net/igb.c
+++ b/hw/net/igb.c
@@ -433,16 +433,16 @@ static void igb_pci_realize(PCIDevice *pci_dev, Error
**errp)
pcie_ari_init(pci_dev, 0x150, 1);
- pcie_sriov_pf_init(pci_dev, IGB_CAP_SRIOV_OFFSET, "igbvf",
+ pcie_sriov_pf_init(pci_dev, IGB_CAP_SRIOV_OFFSET, TYPE_IGBVF,
IGB_82576_VF_DEV_ID, IGB_MAX_VF_FUNCTIONS, IGB_MAX_VF_FUNCTIONS,
IGB_VF_OFFSET, IGB_VF_STRIDE);
- pcie_sriov_pf_init_vf_bar(pci_dev, 0,
+ pcie_sriov_pf_init_vf_bar(pci_dev, IGBVF_MMIO_BAR_IDX,
PCI_BASE_ADDRESS_MEM_TYPE_64 | PCI_BASE_ADDRESS_MEM_PREFETCH,
- 16 * KiB);
- pcie_sriov_pf_init_vf_bar(pci_dev, 3,
+ IGBVF_MMIO_SIZE);
+ pcie_sriov_pf_init_vf_bar(pci_dev, IGBVF_MSIX_BAR_IDX,
PCI_BASE_ADDRESS_MEM_TYPE_64 | PCI_BASE_ADDRESS_MEM_PREFETCH,
- 16 * KiB);
+ IGBVF_MSIX_SIZE);
igb_init_net_peer(s, pci_dev, macaddr);
diff --git a/hw/net/igb_common.h b/hw/net/igb_common.h
index 69ac490..f2a9065 100644
--- a/hw/net/igb_common.h
+++ b/hw/net/igb_common.h
@@ -28,6 +28,14 @@
#include "igb_regs.h"
+#define TYPE_IGBVF "igbvf"
+
+#define IGBVF_MMIO_BAR_IDX (0)
+#define IGBVF_MSIX_BAR_IDX (3)
+
+#define IGBVF_MMIO_SIZE (16 * 1024)
+#define IGBVF_MSIX_SIZE (16 * 1024)
+
#define defreg(x) x = (E1000_##x >> 2)
#define defreg_indexed(x, i) x##i = (E1000_##x(i) >> 2)
#define defreg_indexeda(x, i) x##i##_A = (E1000_##x##_A(i) >> 2)
diff --git a/hw/net/igbvf.c b/hw/net/igbvf.c
index 70beb7a..284ea61 100644
--- a/hw/net/igbvf.c
+++ b/hw/net/igbvf.c
@@ -50,15 +50,8 @@
#include "trace.h"
#include "qapi/error.h"
-#define TYPE_IGBVF "igbvf"
OBJECT_DECLARE_SIMPLE_TYPE(IgbVfState, IGBVF)
-#define IGBVF_MMIO_BAR_IDX (0)
-#define IGBVF_MSIX_BAR_IDX (3)
-
-#define IGBVF_MMIO_SIZE (16 * 1024)
-#define IGBVF_MSIX_SIZE (16 * 1024)
-
struct IgbVfState {
PCIDevice parent_obj;
--
2.7.4
- [PULL 16/50] e1000x: Share more Rx filtering logic, (continued)
- [PULL 16/50] e1000x: Share more Rx filtering logic, Jason Wang, 2023/05/23
- [PULL 17/50] e1000x: Take CRC into consideration for size check, Jason Wang, 2023/05/23
- [PULL 18/50] e1000x: Rename TcpIpv6 into TcpIpv6Ex, Jason Wang, 2023/05/23
- [PULL 19/50] e1000e: Always log status after building rx metadata, Jason Wang, 2023/05/23
- [PULL 20/50] igb: Always log status after building rx metadata, Jason Wang, 2023/05/23
- [PULL 21/50] igb: Remove goto, Jason Wang, 2023/05/23
- [PULL 22/50] igb: Read DCMD.VLE of the first Tx descriptor, Jason Wang, 2023/05/23
- [PULL 23/50] e1000e: Reset packet state after emptying Tx queue, Jason Wang, 2023/05/23
- [PULL 24/50] vmxnet3: Reset packet state after emptying Tx queue, Jason Wang, 2023/05/23
- [PULL 25/50] igb: Add more definitions for Tx descriptor, Jason Wang, 2023/05/23
- [PULL 26/50] igb: Share common VF constants,
Jason Wang <=
- [PULL 27/50] igb: Fix igb_mac_reg_init coding style alignment, Jason Wang, 2023/05/23
- [PULL 28/50] igb: Clear EICR bits for delayed MSI-X interrupts, Jason Wang, 2023/05/23
- [PULL 29/50] e1000e: Rename a variable in e1000e_receive_internal(), Jason Wang, 2023/05/23
- [PULL 31/50] net/eth: Use void pointers, Jason Wang, 2023/05/23
- [PULL 30/50] igb: Rename a variable in igb_receive_internal(), Jason Wang, 2023/05/23
- [PULL 33/50] hw/net/net_rx_pkt: Enforce alignment for eth_header, Jason Wang, 2023/05/23
- [PULL 40/50] igb: Filter with the second VLAN tag for extended VLAN, Jason Wang, 2023/05/23
- [PULL 34/50] tests/qtest/libqos/igb: Set GPIE.Multiple_MSIX, Jason Wang, 2023/05/23
- [PULL 35/50] igb: Implement MSI-X single vector mode, Jason Wang, 2023/05/23
- [PULL 44/50] e1000e: Notify only new interrupts, Jason Wang, 2023/05/23