[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 31/50] net/eth: Use void pointers
|
From: |
Jason Wang |
|
Subject: |
[PULL 31/50] net/eth: Use void pointers |
|
Date: |
Tue, 23 May 2023 15:32:19 +0800 |
From: Akihiko Odaki <akihiko.odaki@daynix.com>
The uses of uint8_t pointers were misleading as they are never accessed
as an array of octets and it even require more strict alignment to
access as struct eth_header.
Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Jason Wang <jasowang@redhat.com>
---
include/net/eth.h | 4 ++--
net/eth.c | 6 +++---
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/include/net/eth.h b/include/net/eth.h
index 05f5693..95ff24d 100644
--- a/include/net/eth.h
+++ b/include/net/eth.h
@@ -342,12 +342,12 @@ eth_get_pkt_tci(const void *p)
size_t
eth_strip_vlan(const struct iovec *iov, int iovcnt, size_t iovoff,
- uint8_t *new_ehdr_buf,
+ void *new_ehdr_buf,
uint16_t *payload_offset, uint16_t *tci);
size_t
eth_strip_vlan_ex(const struct iovec *iov, int iovcnt, size_t iovoff,
- uint16_t vet, uint8_t *new_ehdr_buf,
+ uint16_t vet, void *new_ehdr_buf,
uint16_t *payload_offset, uint16_t *tci);
uint16_t
diff --git a/net/eth.c b/net/eth.c
index b6ff89c..f7ffbda 100644
--- a/net/eth.c
+++ b/net/eth.c
@@ -226,11 +226,11 @@ void eth_get_protocols(const struct iovec *iov, size_t
iovcnt, size_t iovoff,
size_t
eth_strip_vlan(const struct iovec *iov, int iovcnt, size_t iovoff,
- uint8_t *new_ehdr_buf,
+ void *new_ehdr_buf,
uint16_t *payload_offset, uint16_t *tci)
{
struct vlan_header vlan_hdr;
- struct eth_header *new_ehdr = (struct eth_header *) new_ehdr_buf;
+ struct eth_header *new_ehdr = new_ehdr_buf;
size_t copied = iov_to_buf(iov, iovcnt, iovoff,
new_ehdr, sizeof(*new_ehdr));
@@ -276,7 +276,7 @@ eth_strip_vlan(const struct iovec *iov, int iovcnt, size_t
iovoff,
size_t
eth_strip_vlan_ex(const struct iovec *iov, int iovcnt, size_t iovoff,
- uint16_t vet, uint8_t *new_ehdr_buf,
+ uint16_t vet, void *new_ehdr_buf,
uint16_t *payload_offset, uint16_t *tci)
{
struct vlan_header vlan_hdr;
--
2.7.4
- [PULL 20/50] igb: Always log status after building rx metadata, (continued)
- [PULL 20/50] igb: Always log status after building rx metadata, Jason Wang, 2023/05/23
- [PULL 21/50] igb: Remove goto, Jason Wang, 2023/05/23
- [PULL 22/50] igb: Read DCMD.VLE of the first Tx descriptor, Jason Wang, 2023/05/23
- [PULL 23/50] e1000e: Reset packet state after emptying Tx queue, Jason Wang, 2023/05/23
- [PULL 24/50] vmxnet3: Reset packet state after emptying Tx queue, Jason Wang, 2023/05/23
- [PULL 25/50] igb: Add more definitions for Tx descriptor, Jason Wang, 2023/05/23
- [PULL 26/50] igb: Share common VF constants, Jason Wang, 2023/05/23
- [PULL 27/50] igb: Fix igb_mac_reg_init coding style alignment, Jason Wang, 2023/05/23
- [PULL 28/50] igb: Clear EICR bits for delayed MSI-X interrupts, Jason Wang, 2023/05/23
- [PULL 29/50] e1000e: Rename a variable in e1000e_receive_internal(), Jason Wang, 2023/05/23
- [PULL 31/50] net/eth: Use void pointers,
Jason Wang <=
- [PULL 30/50] igb: Rename a variable in igb_receive_internal(), Jason Wang, 2023/05/23
- [PULL 33/50] hw/net/net_rx_pkt: Enforce alignment for eth_header, Jason Wang, 2023/05/23
- [PULL 40/50] igb: Filter with the second VLAN tag for extended VLAN, Jason Wang, 2023/05/23
- [PULL 34/50] tests/qtest/libqos/igb: Set GPIE.Multiple_MSIX, Jason Wang, 2023/05/23
- [PULL 35/50] igb: Implement MSI-X single vector mode, Jason Wang, 2023/05/23
- [PULL 44/50] e1000e: Notify only new interrupts, Jason Wang, 2023/05/23
- [PULL 37/50] igb: Implement Rx SCTP CSO, Jason Wang, 2023/05/23
- [PULL 41/50] igb: Implement igb-specific oversize check, Jason Wang, 2023/05/23
- [PULL 43/50] igb: Implement Tx timestamp, Jason Wang, 2023/05/23
- [PULL 42/50] igb: Implement Rx PTP2 timestamp, Jason Wang, 2023/05/23