[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 46/50] igb: Clear-on-read ICR when ICR.INTA is set
|
From: |
Jason Wang |
|
Subject: |
[PULL 46/50] igb: Clear-on-read ICR when ICR.INTA is set |
|
Date: |
Tue, 23 May 2023 15:32:34 +0800 |
From: Akihiko Odaki <akihiko.odaki@daynix.com>
For GPIE.NSICR, Section 7.3.2.1.2 says:
> ICR bits are cleared on register read. If GPIE.NSICR = 0b, then the
> clear on read occurs only if no bit is set in the IMS or at least one
> bit is set in the IMS and there is a true interrupt as reflected in
> ICR.INTA.
e1000e does similar though it checks for CTRL_EXT.IAME, which does not
exist on igb.
Suggested-by: Sriram Yagnaraman <sriram.yagnaraman@est.tech>
Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
---
hw/net/igb_core.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c
index 823dde8..d00b1ca 100644
--- a/hw/net/igb_core.c
+++ b/hw/net/igb_core.c
@@ -2598,6 +2598,8 @@ igb_mac_icr_read(IGBCore *core, int index)
} else if (core->mac[IMS] == 0) {
trace_e1000e_irq_icr_clear_zero_ims();
igb_lower_interrupts(core, ICR, 0xffffffff);
+ } else if (core->mac[ICR] & E1000_ICR_INT_ASSERTED) {
+ igb_lower_interrupts(core, ICR, 0xffffffff);
} else if (!msix_enabled(core->owner)) {
trace_e1000e_irq_icr_clear_nonmsix_icr_read();
igb_lower_interrupts(core, ICR, 0xffffffff);
--
2.7.4
- [PULL 34/50] tests/qtest/libqos/igb: Set GPIE.Multiple_MSIX, (continued)
- [PULL 34/50] tests/qtest/libqos/igb: Set GPIE.Multiple_MSIX, Jason Wang, 2023/05/23
- [PULL 35/50] igb: Implement MSI-X single vector mode, Jason Wang, 2023/05/23
- [PULL 44/50] e1000e: Notify only new interrupts, Jason Wang, 2023/05/23
- [PULL 37/50] igb: Implement Rx SCTP CSO, Jason Wang, 2023/05/23
- [PULL 41/50] igb: Implement igb-specific oversize check, Jason Wang, 2023/05/23
- [PULL 43/50] igb: Implement Tx timestamp, Jason Wang, 2023/05/23
- [PULL 42/50] igb: Implement Rx PTP2 timestamp, Jason Wang, 2023/05/23
- [PULL 36/50] igb: Use UDP for RSS hash, Jason Wang, 2023/05/23
- [PULL 38/50] igb: Implement Tx SCTP CSO, Jason Wang, 2023/05/23
- [PULL 39/50] igb: Strip the second VLAN tag for extended VLAN, Jason Wang, 2023/05/23
- [PULL 46/50] igb: Clear-on-read ICR when ICR.INTA is set,
Jason Wang <=
- [PULL 50/50] rtl8139: fix large_send_mss divide-by-zero, Jason Wang, 2023/05/23
- [PULL 45/50] igb: Notify only new interrupts, Jason Wang, 2023/05/23
- [PULL 32/50] net/eth: Always add VLAN tag, Jason Wang, 2023/05/23
- [PULL 47/50] vmxnet3: Do not depend on PC, Jason Wang, 2023/05/23
- [PULL 48/50] MAINTAINERS: Add a reviewer for network packet abstractions, Jason Wang, 2023/05/23
- [PULL 49/50] docs/system/devices/igb: Note igb is tested for DPDK, Jason Wang, 2023/05/23
- Re: [PULL 00/50] Net patches, Richard Henderson, 2023/05/23
- Re: [PULL 00/50] Net patches, Michael Tokarev, 2023/05/23