[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 2/3] vhost: Remove vhost_backend_can_merge() callback
|
From: |
Peter Xu |
|
Subject: |
Re: [PATCH v3 2/3] vhost: Remove vhost_backend_can_merge() callback |
|
Date: |
Tue, 23 May 2023 11:40:41 -0400 |
On Wed, May 03, 2023 at 07:21:20PM +0200, David Hildenbrand wrote:
> Checking whether the memory regions are equal is sufficient: if they are
> equal, then most certainly the contained fd is equal.
Looks reasonable to me.
I double checked the src of the change and there's no bug report attached
either. Maybe just a double safety belt, but definitely Michael will know
the best.
https://lore.kernel.org/qemu-devel/1456067090-18187-1-git-send-email-mst@redhat.com/
>
> The whole vhost-user memslot handling is suboptimal and overly
> complicated. We shouldn't have to lookup a RAM memory regions we got
> notified about in vhost_user_get_mr_data() using a host pointer. But that
> requires a bigger rework -- especially an alternative vhost_set_mem_table()
> backend call that simply consumes MemoryRegionSections.
>
> For now, let's just drop vhost_backend_can_merge().
>
> Acked-by: Stefan Hajnoczi <stefanha@redhat.com>
> Reviewed-by: Igor Mammedov <imammedo@redhat.com>
> Acked-by: Igor Mammedov <imammedo@redhat.com>
> Signed-off-by: David Hildenbrand <david@redhat.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
--
Peter Xu