Re: [PATCH 02/27] util: Add cpuinfo-i386.c

[Alex Bennée]

Richard Henderson <richard.henderson@linaro.org> writes:

> On 5/21/23 04:28, Philippe Mathieu-Daudé wrote:
>> On 20/5/23 18:26, Richard Henderson wrote:
>>> Add cpuinfo.h for i386 and x86_64, and the initialization
>>> for that in util/.  Populate that with a slightly altered
>>> copy of the tcg host probing code.  Other uses of cpuid.h
>>> will be adjusted one patch at a time.
>>>
>>> Reviewed-by: Juan Quintela <quintela@redhat.com>
>>> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
>>> ---
>>>   host/include/i386/host/cpuinfo.h   | 38 ++++++++++++
>>>   host/include/x86_64/host/cpuinfo.h |  1 +
>>>   util/cpuinfo-i386.c                | 97 ++++++++++++++++++++++++++++++
>>>   util/meson.build                   |  4 ++
>>>   4 files changed, 140 insertions(+)
>>>   create mode 100644 host/include/i386/host/cpuinfo.h
>>>   create mode 100644 host/include/x86_64/host/cpuinfo.h
>>>   create mode 100644 util/cpuinfo-i386.c
>> Missing F: entry in MAINTAINERS file. We probably need new sections.
>
> What would you put there?

Part of Guest CPU cores (TCG) I guess.

Anyway:

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro