Re: [PULL 00/50] Net patches

[Akihiko Odaki]

On 2023/05/24 13:06, Jason Wang wrote:
> On Wed, May 24, 2023 at 3:54 AM Michael Tokarev <mjt@tls.msk.ru> wrote:
> > 23.05.2023 10:31, Jason Wang wrote:
> >
> > >     https://github.com/jasowang/qemu.git tags/net-pull-request
> >
> > I might be wrong but it looks like besides the rtl8139 fix which went
> > to -stable already, and "e1000e: Fix tx/rx counters" change which has
> > been agreed upon before, there are a few other changes which are worth
> > to have in -stable, in 8.0 and some even in 7.2. What do you think,
> > which ones are important for -stable?
>
> I'm not sure, most fixes are for igb, considering igb is complicated
> and just introduced since 8.0, it should be considered as a technical
> preview somehow. Then I'm not sure whether or not it's worth it to
> backport them. For the rest, it looks like it should be fine to go for
> -stable.
>
> Akihiko, what's your thoughts? >
> Thanks

I think it is fine to backport all of patches with Fixes: tags as there 
are only five such patches for igb. Namely, they are:
- [PULL 05/50] igb: Fix Rx packet type encoding
- [PULL 06/50] igb: Do not require CTRL.VME for tx VLAN tagging
- [PULL 07/50] igb: Clear IMS bits when committing ICR access
- [PULL 08/50] net/net_rx_pkt: Use iovec for net_rx_pkt_set_protocols()
- [PULL 10/50] igb: Always copy ethernet header

That said, if that looks too many, you may backport only the last two 
patches, which fixes possible out-of-bounds accesses:
- [PULL 08/50] net/net_rx_pkt: Use iovec for net_rx_pkt_set_protocols()
- [PULL 10/50] igb: Always copy ethernet header

The other patches are just behavioral changes which do not corrupt QEMU 
state so they are not that important.

Regards,
Akihiko Odaki