[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v2 2/2] Hexagon: fix outdated `hex_new_*` comments
|
From: |
Taylor Simpson |
|
Subject: |
RE: [PATCH v2 2/2] Hexagon: fix outdated `hex_new_*` comments |
|
Date: |
Wed, 24 May 2023 16:43:01 +0000 |
> -----Original Message-----
> From: Matheus Tavares Bernardino <quic_mathbern@quicinc.com>
> Sent: Wednesday, May 24, 2023 9:42 AM
> To: qemu-devel@nongnu.org
> Cc: Taylor Simpson <tsimpson@quicinc.com>; Brian Cain
> <bcain@quicinc.com>; Marco Liebel (QUIC) <quic_mliebel@quicinc.com>
> Subject: [PATCH v2 2/2] Hexagon: fix outdated `hex_new_*` comments
>
> Some code comments refer to hex_new_value and hex_new_pred_value,
> which have been transferred to DisasContext and, in the case of
> hex_new_value, should now be accessed through get_result_gpr().
>
> In order to fix this outdated comments and also avoid having to tweak them
> whenever we make a variable name change in the future, let's replace them
> with pseudocode.
>
> Suggested-by: Taylor Simpson <tsimpson@quicinc.com>
> Signed-off-by: Matheus Tavares Bernardino <quic_mathbern@quicinc.com>
> ---
> target/hexagon/genptr.c | 26 ++++++++++++--------------
> target/hexagon/translate.c | 2 +-
> 2 files changed, 13 insertions(+), 15 deletions(-)
Reviewed-by: Taylor Simpson <tsimpson@quicinc.com>
Queued to hex.next