Re: [PATCH 07/10] hw/arm/realview: Move 'mpcore_periphbase' to RealviewMachineClass

[Richard Henderson]

On 5/24/23 07:59, Philippe Mathieu-Daudé wrote:
> -    int is_mpcore = 0;
> +    bool is_mpcore = rmc->mpcore_periphbase != 0;
>       bool is_pb = rmc->is_pb;
>       uint32_t proc_id = 0;
>       uint32_t sys_id;
>       ram_addr_t low_ram_size;
>       ram_addr_t ram_size = machine->ram_size;
> -    hwaddr periphbase = 0;

hwaddr periphbase = rmc->mpcore_periphbase;
bool is_mpcore = periphbase != 0;

would be cleaner and require fewer changes.

Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~