[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 22/30] mac_via: fix rtc command decoding from PRAM addresses 0x0
|
From: |
Mark Cave-Ayland |
|
Subject: |
[PATCH 22/30] mac_via: fix rtc command decoding from PRAM addresses 0x0 to 0xf |
|
Date: |
Wed, 24 May 2023 22:10:56 +0100 |
A comparison between the rtc command table included in the comment and the code
itself shows that the decoding for PRAM addresses 0x0 to 0xf is being done on
the raw command, and not the shifted version held in value.
Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
---
hw/misc/mac_via.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/misc/mac_via.c b/hw/misc/mac_via.c
index 62f0988537..d7067030db 100644
--- a/hw/misc/mac_via.c
+++ b/hw/misc/mac_via.c
@@ -403,7 +403,7 @@ static int via1_rtc_compact_cmd(uint8_t value)
} else if ((value & 0x1c) == 0x08) {
/* RAM address 0x10 to 0x13 */
return read | (REG_PRAM_ADDR + 0x10 + (value & 0x03));
- } else if ((value & 0x43) == 0x41) {
+ } else if ((value & 0x10) == 0x10) {
/* RAM address 0x00 to 0x0f */
return read | (REG_PRAM_ADDR + (value & 0x0f));
}
--
2.30.2
- Re: [PATCH 14/30] audio: add Apple Sound Chip (ASC) emulation, (continued)
- [PATCH 15/30] asc: generate silence if FIFO empty but engine still running, Mark Cave-Ayland, 2023/05/24
- [PATCH 17/30] q800: add easc bool machine class property to switch between ASC and EASC, Mark Cave-Ayland, 2023/05/24
- [PATCH 19/30] swim: split into separate IWM and ISM register blocks, Mark Cave-Ayland, 2023/05/24
- [PATCH 18/30] swim: add trace events for IWM and ISM registers, Mark Cave-Ayland, 2023/05/24
- [PATCH 22/30] mac_via: fix rtc command decoding from PRAM addresses 0x0 to 0xf,
Mark Cave-Ayland <=
- [PATCH 21/30] mac_via: work around underflow in TimeDBRA timing loop in SETUPTIMEK, Mark Cave-Ayland, 2023/05/24
- [PATCH 23/30] mac_via: fix rtc command decoding for the PRAM seconds registers, Mark Cave-Ayland, 2023/05/24
- [PATCH 20/30] swim: update IWM/ISM register block decoding, Mark Cave-Ayland, 2023/05/24
- [PATCH 24/30] mac_via: workaround NetBSD ADB bus enumeration issue, Mark Cave-Ayland, 2023/05/24
- [PATCH 25/30] mac_via: implement ADB_STATE_IDLE state if shift register in input mode, Mark Cave-Ayland, 2023/05/24
- [PATCH 16/30] q800: add Apple Sound Chip (ASC) audio to machine, Mark Cave-Ayland, 2023/05/24
- [PATCH 27/30] q800: add ESCC alias at 0xc000, Mark Cave-Ayland, 2023/05/24
- [PATCH 28/30] q800: add alias for MacOS toolbox ROM at 0x40000000, Mark Cave-Ayland, 2023/05/24