Re: [PATCH 1/2] docs: sbsa: correct graphics card name

[Thomas Huth]

On 25/05/2023 12.05, Peter Maydell wrote:
> On Tue, 23 May 2023 at 19:41, Thomas Huth <thuth@redhat.com> wrote:
> > On 23/05/2023 19.30, Marcin Juszkiewicz wrote:
> > ...
> > > > (is there a reason why it can't be disabled with "-vga none" or
> > > > "-nodefaults"?)
> > >
> > > That's something I need to check how it should be done.
> >
> > Other boards set mc->default_display in their ...class_init
> > function and then use pci_vga_init() (or vga_interface_type)
> > to instantiate their default display adapter ... however, that
> > does not seem to support the bochs adapter yet (see
> > vga_interfaces[] in softmmu/vl.c).
> >
> > Not sure whether it's worth the effort to extend vga_interfaces[]
> > in vl.c
>
> Isn't that a legacy-command-line-option thing? I feel like
> the recommended way to select a different graphics card
> these days would be to use -device my-pci-vga-card ...

"-vga" is kind of legacy, indeed, but currently the sbsa-ref hard-codes the 
graphics card to be always available, so if you add a "-device 
something-vga-card" on the command line, you'd get two graphic cards on your 
machine, even if you use -nodefaults.

So there needs to be at least some logic dealing with vga_interface_type if 
we want to be able to select a different graphics card for this machine. 
Then why not go the full way and use pci_vga_init() here, too? ... that's 
certainly the least confusing way for the users.

 Thomas