Re: [PATCH 2/4] tests/qtest: Check for virtio-blk before using -cdrom with the arm virt machine

[Fabiano Rosas]

Thomas Huth <thuth@redhat.com> writes:

> The arm "virt" machine needs "virtio-blk-pci" for devices that get attached
> via the "-cdrom" option. Since this is an optional device that might not
> be available in the binary, we should check for the availability of this
> device first before using it.
>

We're still producing a binary that exposes runtime options that may not
work depending on the state of seemingly unrelated config options. And
barfs QEMU implementation details at the user:

qemu-system-aarch64: -cdrom foo.qcow2: 'virtio-blk' (alias
'virtio-blk-pci') is not a valid device model name

Anyway, this patch is good so:

Reviewed-by: Fabiano Rosas <farosas@suse.de>