[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 13/20] monitor: allow calling monitor_resume under mon_lock
|
From: |
Paolo Bonzini |
|
Subject: |
[PULL 13/20] monitor: allow calling monitor_resume under mon_lock |
|
Date: |
Thu, 25 May 2023 16:15:25 +0200 |
Move monitor_resume()'s call to readline_show_prompt() outside the
potentially locked section. Reuse the existing monitor_accept_input()
bottom half for this purpose.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
monitor/monitor.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/monitor/monitor.c b/monitor/monitor.c
index 4b11bca2a21d..7080d2da8ec6 100644
--- a/monitor/monitor.c
+++ b/monitor/monitor.c
@@ -567,6 +567,12 @@ static void monitor_accept_input(void *opaque)
{
Monitor *mon = opaque;
+ if (!monitor_is_qmp(mon)) {
+ MonitorHMP *hmp_mon = container_of(mon, MonitorHMP, common);
+ assert(hmp_mon->rs);
+ readline_show_prompt(hmp_mon->rs);
+ }
+
qemu_chr_fe_accept_input(&mon->chr);
}
@@ -585,12 +591,6 @@ void monitor_resume(Monitor *mon)
ctx = qemu_get_aio_context();
}
- if (!monitor_is_qmp(mon)) {
- MonitorHMP *hmp_mon = container_of(mon, MonitorHMP, common);
- assert(hmp_mon->rs);
- readline_show_prompt(hmp_mon->rs);
- }
-
aio_bh_schedule_oneshot(ctx, monitor_accept_input, mon);
}
--
2.40.1
- [PULL 00/20] Misc patches for 2023-05-25, Paolo Bonzini, 2023/05/25
- [PULL 02/20] meson.build: Fix glib -Wno-unused-function workaround, Paolo Bonzini, 2023/05/25
- [PULL 01/20] target/i386: EPYC-Rome model without XSAVES, Paolo Bonzini, 2023/05/25
- [PULL 05/20] tests/docker: simplify HOST_ARCH definition, Paolo Bonzini, 2023/05/25
- [PULL 08/20] usb/ohci: Set pad to 0 after frame update, Paolo Bonzini, 2023/05/25
- [PULL 04/20] meson: move -no-pie from linker to compiler, Paolo Bonzini, 2023/05/25
- [PULL 07/20] Makefile: remove $(TESTS_PYTHON), Paolo Bonzini, 2023/05/25
- [PULL 03/20] meson: fix rule for qemu-ga installer, Paolo Bonzini, 2023/05/25
- [PULL 13/20] monitor: allow calling monitor_resume under mon_lock,
Paolo Bonzini <=
- [PULL 17/20] monitor: cleanup fetching of QMP requests, Paolo Bonzini, 2023/05/25
- [PULL 20/20] monitor: do not use mb_read/mb_set, Paolo Bonzini, 2023/05/25
- [PULL 18/20] monitor: introduce qmp_dispatcher_co_wake, Paolo Bonzini, 2023/05/25
- [PULL 06/20] tests/vm: fix and simplify HOST_ARCH definition, Paolo Bonzini, 2023/05/25
- [PULL 10/20] softmmu/ioport.c: QOMify MemoryRegionPortioList, Paolo Bonzini, 2023/05/25
- [PULL 09/20] softmmu/ioport.c: allocate MemoryRegionPortioList ports on the heap, Paolo Bonzini, 2023/05/25
- [PULL 14/20] monitor: add more *_locked() functions, Paolo Bonzini, 2023/05/25
- [PULL 11/20] softmmu/ioport.c: make MemoryRegionPortioList owner of portio_list MemoryRegions, Paolo Bonzini, 2023/05/25
- [PULL 12/20] monitor: use QEMU_LOCK_GUARD a bit more, Paolo Bonzini, 2023/05/25
- [PULL 16/20] monitor: cleanup detection of qmp_dispatcher_co shutting down, Paolo Bonzini, 2023/05/25