[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 03/12] block: Take main AioContext lock when calling bdrv_ope
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [PATCH 03/12] block: Take main AioContext lock when calling bdrv_open() |
|
Date: |
Thu, 25 May 2023 14:20:32 -0400 |
On Thu, May 25, 2023 at 02:47:04PM +0200, Kevin Wolf wrote:
> The function documentation already says that all callers must hold the
> main AioContext lock, but not all of them do. This can cause assertion
> failures when functions called by bdrv_open() try to drop the lock. Fix
> a few more callers to take the lock before calling bdrv_open().
Did you audit the code to check that there are no cases where
aio_context_acquire() is now called twice, leading to aio_poll() hangs?
Otherwise:
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
signature.asc
Description: PGP signature