qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] vhost: release memory objects in error path


From: Prasad Pandit
Subject: Re: [PATCH] vhost: release memory objects in error path
Date: Fri, 26 May 2023 12:24:07 +0530

Hello Peter, all

On Thu, 25 May 2023 at 18:33, Peter Xu <peterx@redhat.com> wrote:
IIRC this bug used to only reproduce on rt kernels, is it still the case?

* Yes, it's a same crash.
 
Here besides doing correct unregister, does it also mean that even if
event_notifier_init() failed there's totally no error message anywhere?
Should we dump something when it fails?  And did you check why that failed?

* In the qemu logs we see following error

        VHOST_OPS_DEBUG(r, "vhost_set_mem_table failed");
        goto fail_mem

After this execution likely did not reach the event_notifier_init() call, because: goto fail_mem.

* But in case it fails, no error message gets logged. Do we want to add it in this same patch?

Thank you.
---
  - Prasad

reply via email to

[Prev in Thread] Current Thread [Next in Thread]