Re: [PATCH 6/6] tests/decode: Add tests for various named-field cases

[Richard Henderson]

On 5/24/23 03:26, Peter Maydell wrote:
> On Tue, 23 May 2023 at 13:04, Peter Maydell <peter.maydell@linaro.org> wrote:
> > Add some tests for various cases of named-field use, both ones that
> > should work and ones that should be diagnosed as errors.
> >
> > Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> > ---
> >   tests/decode/err_field1.decode       |  2 +-
> >   tests/decode/err_field10.decode      |  7 +++++++
> >   tests/decode/err_field7.decode       |  7 +++++++
> >   tests/decode/err_field8.decode       |  8 ++++++++
> >   tests/decode/err_field9.decode       | 14 ++++++++++++++
> >   tests/decode/succ_named_field.decode | 19 +++++++++++++++++++
> >   6 files changed, 56 insertions(+), 1 deletion(-)
> >   create mode 100644 tests/decode/err_field10.decode
> >   create mode 100644 tests/decode/err_field7.decode
> >   create mode 100644 tests/decode/err_field8.decode
> >   create mode 100644 tests/decode/err_field9.decode
> >   create mode 100644 tests/decode/succ_named_field.decode
> >
> > diff --git a/tests/decode/err_field1.decode b/tests/decode/err_field1.decode
> > index e07a5a73e0e..85c3f326d07 100644
> > --- a/tests/decode/err_field1.decode
> > +++ b/tests/decode/err_field1.decode
> > @@ -2,4 +2,4 @@
> >   # See the COPYING.LIB file in the top-level directory.
> >
> >   # Diagnose invalid field syntax
> > -%field asdf
> > +%field 1asdf
>
> I just realized that this specific change needs to go before patch 5:
> it's updating an existing test because "asdf" used to be invalid
> syntax and now is not. Otherwise bisection will break.

Really?  The test still fails here at patch 5:

/home/rth/qemu/bld/../src/tests/decode/err_field1.decode:5: error: invalid field token 
"asdf"


r~