qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] meson: Avoid implicit declaration of functions


From: Michael Tokarev
Subject: Re: [PATCH] meson: Avoid implicit declaration of functions
Date: Mon, 29 May 2023 14:13:22 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0

29.05.2023 10:56, Michal Privoznik пишет:
While detecting a presence of a function via 'cc.links()'
gives desired result (i.e. detects whether function is present),
it also produces a warning on systems where the function is not
present, e.g.:

   qemu.git/build/meson-private/tmph74x3p38/testfile.c:2:34: \
   warning: implicit declaration of function 'malloc_trim' 
[-Wimplicit-function-declaration]

We can check whether given function exists via
'cc.has_function()' firstly.

This just slows down the configure step, it looks like.
Shouldn't we use cc.has_function() *instead* of our cc.links(),
but not both?

/mjt



reply via email to

[Prev in Thread] Current Thread [Next in Thread]