Re: [PATCH v5 8/9] migration: Introduced MigrateChannelList struct to migration code flow.

[Het Gala]

On 25/05/23 11:32 pm, Markus Armbruster wrote:
> Het Gala <het.gala@nutanix.com> writes:
>
> > Integrated MigrateChannelList with all transport backends (socket, exec
> > and rdma) for both source and destination migration code flow.
> >
> > Suggested-by: Aravind Retnakaran <aravind.retnakaran@nutanix.com>
> > Signed-off-by: Het Gala <het.gala@nutanix.com>
> clang warns for me:
>
> ../migration/migration.c:497:13: warning: variable 'addrs' is used 
> uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
>          if (uri && !migrate_uri_parse(uri, &channel, errp)) {
>              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../migration/migration.c:503:54: note: uninitialized use occurs here
>      if (!migration_channels_and_transport_compatible(addrs, errp)) {
>                                                       ^~~~~
> ../migration/migration.c:497:9: note: remove the 'if' if its condition is 
> always true
>          if (uri && !migrate_uri_parse(uri, &channel, errp)) {
>          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../migration/migration.c:497:13: warning: variable 'addrs' is used uninitialized 
> whenever '&&' condition is false [-Wsometimes-uninitialized]
>          if (uri && !migrate_uri_parse(uri, &channel, errp)) {
>              ^~~
> ../migration/migration.c:503:54: note: uninitialized use occurs here
>      if (!migration_channels_and_transport_compatible(addrs, errp)) {
>                                                       ^~~~~
> ../migration/migration.c:497:13: note: remove the '&&' if its condition is 
> always true
>          if (uri && !migrate_uri_parse(uri, &channel, errp)) {
>              ^~~~~~
> ../migration/migration.c:477:36: note: initialize the variable 'addrs' to 
> silence this warning
>      g_autoptr(MigrateAddress) addrs;
>                                     ^
>                                      = NULL
> ../migration/migration.c:1735:13: warning: variable 'addrs' is used 
> uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
>          if (uri && !migrate_uri_parse(uri, &channel, errp)) {
>              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../migration/migration.c:1741:54: note: uninitialized use occurs here
>      if (!migration_channels_and_transport_compatible(addrs, errp)) {
>                                                       ^~~~~
> ../migration/migration.c:1735:9: note: remove the 'if' if its condition is 
> always true
>          if (uri && !migrate_uri_parse(uri, &channel, errp)) {
>          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../migration/migration.c:1735:13: warning: variable 'addrs' is used uninitialized 
> whenever '&&' condition is false [-Wsometimes-uninitialized]
>          if (uri && !migrate_uri_parse(uri, &channel, errp)) {
>              ^~~
> ../migration/migration.c:1741:54: note: uninitialized use occurs here
>      if (!migration_channels_and_transport_compatible(addrs, errp)) {
>                                                       ^~~~~
> ../migration/migration.c:1735:13: note: remove the '&&' if its condition is 
> always true
>          if (uri && !migrate_uri_parse(uri, &channel, errp)) {
>              ^~~~~~
> ../migration/migration.c:1715:36: note: initialize the variable 'addrs' to 
> silence this warning
>      g_autoptr(MigrateAddress) addrs;
>                                     ^
>                                      = NULL
> 4 warnings generated.

Thankyou Markus. Will look into it once again, and make changes in the 
next patchset version.

Regards,
Het Gala