[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 16/17] i386: Use CPUCacheInfo.share_level to encode CPUID[0x80
|
From: |
Zhao Liu |
|
Subject: |
[PATCH v2 16/17] i386: Use CPUCacheInfo.share_level to encode CPUID[0x8000001D].EAX[bits 25:14] |
|
Date: |
Mon, 29 May 2023 20:31:00 +0800 |
From: Zhao Liu <zhao1.liu@intel.com>
CPUID[0x8000001D].EAX[bits 25:14] is used to represent the cache
topology for amd CPUs.
After cache models have topology information, we can use
CPUCacheInfo.share_level to decide which topology level to be encoded
into CPUID[0x8000001D].EAX[bits 25:14].
Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
---
Changes since v1:
* Use cache->share_level as the parameter in
max_processor_ids_for_cache().
---
target/i386/cpu.c | 10 +---------
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/target/i386/cpu.c b/target/i386/cpu.c
index 7d3af82c353f..e426f852ed3a 100644
--- a/target/i386/cpu.c
+++ b/target/i386/cpu.c
@@ -361,20 +361,12 @@ static void encode_cache_cpuid8000001d(CPUCacheInfo
*cache,
uint32_t *eax, uint32_t *ebx,
uint32_t *ecx, uint32_t *edx)
{
- uint32_t num_apic_ids;
assert(cache->size == cache->line_size * cache->associativity *
cache->partitions * cache->sets);
*eax = CACHE_TYPE(cache->type) | CACHE_LEVEL(cache->level) |
(cache->self_init ? CACHE_SELF_INIT_LEVEL : 0);
-
- /* L3 is shared among multiple cores */
- if (cache->level == 3) {
- num_apic_ids = 1 << apicid_die_offset(topo_info);
- } else {
- num_apic_ids = 1 << apicid_core_offset(topo_info);
- }
- *eax |= (num_apic_ids - 1) << 14;
+ *eax |= max_processor_ids_for_cache(topo_info, cache->share_level) << 14;
assert(cache->line_size > 0);
assert(cache->partitions > 0);
--
2.34.1
- [PATCH v2 05/17] i386/cpu: Use APIC ID offset to encode cache topo in CPUID[4], (continued)
- [PATCH v2 05/17] i386/cpu: Use APIC ID offset to encode cache topo in CPUID[4], Zhao Liu, 2023/05/29
- [PATCH v2 10/17] i386/cpu: Introduce cluster-id to X86CPU, Zhao Liu, 2023/05/29
- [PATCH v2 11/17] tests: Add test case of APIC ID for module level parsing, Zhao Liu, 2023/05/29
- [PATCH v2 04/17] i386/cpu: Fix i/d-cache topology to core level for Intel CPU, Zhao Liu, 2023/05/29
- [PATCH v2 03/17] softmmu: Fix CPUSTATE.nr_cores' calculation, Zhao Liu, 2023/05/29
- [PATCH v2 08/17] i386: Support modules_per_die in X86CPUTopoInfo, Zhao Liu, 2023/05/29
- [PATCH v2 12/17] hw/i386/pc: Support smp.clusters for x86 PC machine, Zhao Liu, 2023/05/29
- [PATCH v2 14/17] i386: Use CPUCacheInfo.share_level to encode CPUID[4], Zhao Liu, 2023/05/29
- [PATCH v2 13/17] i386: Add cache topology info in CPUCacheInfo, Zhao Liu, 2023/05/29
- [PATCH v2 15/17] i386: Fix NumSharingCache for CPUID[0x8000001D].EAX[bits 25:14], Zhao Liu, 2023/05/29
- [PATCH v2 16/17] i386: Use CPUCacheInfo.share_level to encode CPUID[0x8000001D].EAX[bits 25:14],
Zhao Liu <=
- [PATCH v2 17/17] i386: Add new property to control L2 cache topo in CPUID.04H, Zhao Liu, 2023/05/29